From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 809D73CB35 for ; Fri, 3 May 2019 15:13:12 -0400 (EDT) Received: by mail-lf1-f66.google.com with SMTP id h126so5147116lfh.4 for ; Fri, 03 May 2019 12:13:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=gKGhmZUh/3cXHpr1zz7vupR965CvE//+yf4wBK3e6w4=; b=dFDSbeOmb1NBtX25bLlzPcKB5bMBvHbm0boCE3QCbGLq0fPpgaxj+qO5y5mVeaIauv n4EDyi2vSxKTpzd4WTZ8FVL4dnu44y5mMAoyWTmtdqg+waQ+Pn9dB64nOiJKpeXe7PxS WCqSSleEDYc1AAv4XPKHqCOfr0cIQV6nSvTIJaR6bhC5FDaopDWLXUZQJ+xMGKPLZk0w eSAmA6Q4YpNGLy/TUwBNX+YQOs6y0YdqqoPANtpCb5O9R4K78lPSYDfCet7Ij//ZzUs4 OvMxdpAuWnbYg35FQ5MVJkDZRbNnyUeLJ567+k5Bh58KjjyYptTsApUmwNjd2uicKD3J iBYw== X-Gm-Message-State: APjAAAUJAovwRvI4gQsth7X/w2oRTHblQVnkxaIgjB6cCcLVe0yJe5td Pfpk8UsHJvRWcn83YKj+a+kNVA== X-Google-Smtp-Source: APXvYqxZEX1CGebJHfrdU2oPsvjV9PrtyigTm/Nh8BoPy0GFcX9gzYQR6MdZnOEqcePjhb2dA48Wew== X-Received: by 2002:ac2:5582:: with SMTP id v2mr5886964lfg.19.1556910791399; Fri, 03 May 2019 12:13:11 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id r3sm544255ljr.7.2019.05.03.12.13.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 12:13:10 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id BDCAB1800E2; Fri, 3 May 2019 21:13:09 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant , Jonathan Morton Cc: Cake List In-Reply-To: <05CE7D6A-0A66-4540-A398-B5D6FC4EF06B@darbyshire-bryant.me.uk> References: <493B2B95-93C5-4CEB-906E-CFF0BF3187E9@darbyshire-bryant.me.uk> <069B5A62-314A-4559-8D6C-C67A5D1FE75F@gmail.com> <05CE7D6A-0A66-4540-A398-B5D6FC4EF06B@darbyshire-bryant.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 03 May 2019 21:13:09 +0200 Message-ID: <87h8abgxmi.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Possible conntrack lookup improvements X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 19:13:12 -0000 Kevin Darbyshire-Bryant writes: >> On 3 May 2019, at 15:16, Jonathan Morton wrote: >>=20 >>> On 3 May, 2019, at 4:55 pm, Kevin Darbyshire-Bryant wrote: >>>=20 >>> Two patches attached - one is a simple variable elimination with no fun= ctional change. The second changes/simplifies the conntrack tuple lookup &= usage. I=E2=80=99ve had a play and I don=E2=80=99t think I=E2=80=99ve bro= ken any of the host fairness BUT it could do with some more testing, that= =E2=80=99s where you come in=E2=80=A6=20 >>=20 >> Looks like sound logic, as long as it does actually work. It could be a= useful speedup for those small CPE devices which need NAT and host-fairnes= s working. > > It=E2=80=99s interesting you bring that up - are we sure that ingress hos= t NAT > fairness works in the upstream kernel version of CAKE anyway? I=E2=80=99m > looking at cake_update_flowkeys(=E2=80=A6) and thinking half of it is mis= sing? No, it's just moved into nf_conntrack_get_tuple_skb(); this was part of the work we did to ensure sch_cake could load without a dependency on the conntrack module... It does carry over the 'nf_ct_tuple(ct, !hash->tuple.dst.dir);' and the subsequent reversion, though, but I think the logic fits what's in the out-of-tree version? -Toke