From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3179B3CB35 for ; Thu, 28 Feb 2019 06:13:41 -0500 (EST) Received: by mail-ed1-f53.google.com with SMTP id p27so16633017edc.6 for ; Thu, 28 Feb 2019 03:13:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=9Rxl8pN17o3j94LVp1z02daKy3XTYIdCPyrfR9zqMuk=; b=d3/0BgKpNGVtTKLD/w58KDuSvv8a4YVzNZviku4O/bucZ0lV/KNkSkZqSUQD6cTrPr iwBinZ50MpB41dvEknSoVdm3LmhTDWVIyQxAcNAo/okNcIlYhsiMgVB+3BCmOYiozVeg 5EZbq3J0GTtztKbCAXNmpw5x9T62WpoRCNMAV513lP4umhC1kjNNAiIapMXeG2jbPzX7 wXLE7k8vQP+tTh7RVby2MO8U8FZgxcJxZkmmo5mhxBrHA7Fb0FF25jjZL4A10KayOnoV rL44NRyI9sknfw3l2dLW6by2q42Wubgu1rHcWMikwG+hqAMgzgKFl+TuWwbG0tXuMpDg b/eg== X-Gm-Message-State: AHQUAuaTOo98a7x8qLYJ5BdcpiAVGsE/wkQPooFmG463P6L/XZBc8QDk Ufnb6IwiwxqJ4gw8We/VMpNmyA== X-Google-Smtp-Source: AHgI3IaMuwdcn3TDh+/BlccqxG0xs/f0QsJnEr4jW1xXgvE9IzllkhBzC5GkOK45hgQc8WcU0E9Z5g== X-Received: by 2002:a17:906:49c3:: with SMTP id w3mr5082544ejv.148.1551352420218; Thu, 28 Feb 2019 03:13:40 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id b5sm3128711eju.74.2019.02.28.03.13.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 03:13:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DD9E6183BB9; Thu, 28 Feb 2019 12:13:38 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant Cc: "cake\@lists.bufferbloat.net" In-Reply-To: <2C62593E-9FF1-45C6-8FF9-EFC373E870BB@darbyshire-bryant.me.uk> References: <80982C93-462E-4DE0-B051-E8B30DFCEBFD@darbyshire-bryant.me.uk> <87pnrdmfgn.fsf@toke.dk> <87k1hkme6f.fsf@toke.dk> <2C62593E-9FF1-45C6-8FF9-EFC373E870BB@darbyshire-bryant.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 28 Feb 2019 12:13:38 +0100 Message-ID: <87h8comahp.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Using firewall connmarks as tin selectors X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 11:13:41 -0000 Kevin Darbyshire-Bryant writes: >> On 28 Feb 2019, at 09:54, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >>> I also equally aware that this is =E2=80=98creeping featuritis=E2=80=99= and doing >>> nothing to speed cake up=E2=80=A6 >>=20 >> Yeah, this is the crux of the issue, really: it's a tradeoff between >> ease of use and featuritis. Now in this case the actual impact is a >> single check it might actually be acceptable >>=20 >>> actually I may have improved BESTEFFORT a little - we no longer look >>> for matching TC Major numbers if there=E2=80=99s no actual choice of ti= n to be >>> made :-) >>=20 >> Well, you made the besteffort case slightly faster, but every other mode >> slightly slower... :) > > Ah, ok, tc filter really is king ;-) Well, I don't mind doing the simplification, but it should be done as a separate commit; I'll do that after mering your pull request. >> If you are going to send a patch (or pull request), please leave out the >> refactoring, and only include the feature. This makes it easier to see >> the impact of the feature addition on its own. > > Ha ha, sending a patch to the kernel lists??? Never again! Haha, no, I meant to this list. I'll submit upstream, along with the other stuff. > The non-refactored version is > https://github.com/ldir-EDB0/sch_cake/commit/f30bb18adc97c827c81c9a3297ab= 14bfaf2adcb0 > and I=E2=80=99ve created a PR Great, thanks! >> Also, I assume you have a companion patch for iproute2 somewhere? > > In the first email: https://github.com/ldir-EDB0/tc-adv/commits/fwmark > - based on 4.20.0 =E2=80=98cos that=E2=80=99s where openwrt is at the mom= ent. A pull request against tc-adv would be useful :) > When I=E2=80=99ve found a suitable editor I was even going to update the = man > page! I usually just use a regular editor and copy-paste the syntax bits from another entry... -Toke