From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DC6643EEE7 for ; Mon, 14 May 2018 05:08:37 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1526288916; bh=T1w0QoBuawbFjgYebennzWsMM716CVSvySBGoLtAW2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JxKJfJCyKgoXmrcXWTh/9vBdkDNI1xcmnUnHIC/n2x9zFFaKO9QZJXrP43HW8RYt1 FcRTd669jgUq7/pBqO6Kz5uxMCMDjZk6Tits/HYR4UAv+a2smDfrBULeoX2OzpDCF4 pieubFpqsiUEChFcNcWqWIBihZGVlFjSbngKVfbwq4wDc/Myd96nn4supCr1+65JdH LXcu2JPmxt8oq65UyR3hduvmCR/SKNXUrtBJv+19AQkieMsVHiF5FqQ09AKyI/sS68 zs3lyfGpISOe8VQFCBjMd8nzpvWxnx1nJS2t8eXqHcVHFIDFbiusrZSgWmpObBbyNE Xmj96gpJan0Pg== To: David Miller Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net In-Reply-To: <20180513.200948.1658763899383204062.davem@davemloft.net> References: <152578993399.4805.688094683770472380.stgit@alrua-kau> <152579005972.4805.2514975750552805066.stgit@alrua-kau> <20180513.200948.1658763899383204062.davem@davemloft.net> Date: Mon, 14 May 2018 11:08:28 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87h8nawqnn.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 09:08:38 -0000 David Miller writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > Date: Tue, 08 May 2018 16:34:19 +0200 > >> +struct cake_flow { >> + /* this stuff is all needed per-flow at dequeue time */ >> + struct sk_buff *head; >> + struct sk_buff *tail; > > Please do not invent your own SKB list handling mechanism. We didn't invent it, we inherited it from fq_codel. I was actually about to fix that, but then I noticed it was still around in fq_codel, and so let it be. I can certainly fix it anyway, but, erm, why is it acceptable in fq_codel but not in cake? struct sk_buff_head is not that new, is it? >> +static void cake_heapify(struct cake_sched_data *q, u16 i) >> +{ >> + static const u32 a =3D CAKE_MAX_TINS * CAKE_QUEUES; >> + u32 m =3D i; >> + u32 mb =3D cake_heap_get_backlog(q, m); > > Please order local variables from longest to shortest line. > > The entire submissions has this problem all over the place, please > correct it patch-series wide. Right-oh, one plantation of reverse christmas trees coming right up :) -Toke