From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 016083CB47 for ; Wed, 7 Mar 2018 07:59:58 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520427597; bh=5vEvxeL4CTXCzPcA9iV059idUAVCT9szXP8Lb3W9its=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PwDvWDK6w3kg9gKtLcrAtSwGZaTZyzyKgwIKdiqfH1YvVvSnFM3jOii2L555maOLT +iOtfX2Ur+1eZR/qR0lOD9AOgheD+Tf56pv1NdklNdPJgL5LfG7clNmmgzRWmoRPoO J38kTGmdaTZwZYRyCZ7GFwuSm785RkmM5NK863VZoUd+YmsBN5qD9vkZJc9NmaQXn7 6AaXLl62ZxmWjstV8ElaJuiEIYZ7txINCDnUeiz93b6qRDosJNnvh/+gZ9OMvJPqvn G88+nenYm1k4DXTZo87HeSB67g+X3wYVwIwTvHOEQ21CMN2eKkZ5gRVNsl5hdjlq5S m/sLRSOwhfjdg== To: Kevin Darbyshire-Bryant Cc: Jonathan Morton , "cake\@lists.bufferbloat.net" In-Reply-To: <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> Date: Wed, 07 Mar 2018 13:59:57 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87h8psyraq.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 12:59:59 -0000 Kevin Darbyshire-Bryant writes: > I don=E2=80=99t the column alignment can be correct because the print lin= es don=E2=80=99t include a leading space, so columns can run into each othe= r. > > fprintf(f, "%12u", tst->unresponse_flows); > v > fprintf(f, " %12u", tst->unresponse_flows); > > The header lines are probably wrong. Should be as per > https://github.com/ldir-EDB0/iproute2-cake-next/commit/172c116722e2902bdc= 69824271303dac7249f379 Ah, right; ported that change over to the tc-adv repo as well. Which brings us down to the following diff: diff --git a/tc/q_cake.c b/tc/q_cake.c index e21552e8..95301b41 100644 --- a/tc/q_cake.c +++ b/tc/q_cake.c @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int = argc, char **argv, /* Typical VDSL2 framing schemes, both over PTM */ /* PTM has 64b/65b coding which absorbs some bandwidth */ } else if (strcmp(*argv, "pppoe-ptm") =3D=3D 0) { + /* 2B PPP + 6B PPPoE + 6B dest MAC + 6B src MAC + * + 2B ethertype + 4B Frame Check Sequence + * + 1B Start of Frame (S) + 1B End of Frame (Ck) + * + 2B TC-CRC (PTM-FCS) =3D 30B + */ atm =3D 2; - overhead +=3D 27; + overhead +=3D 30; overhead_set =3D true; } else if (strcmp(*argv, "bridged-ptm") =3D=3D 0) { + /* 6B dest MAC + 6B src MAC + 2B ethertype + * + 4B Frame Check Sequence + * + 1B Start of Frame (S) + 1B End of Frame (Ck) + * + 2B TC-CRC (PTM-FCS) =3D 22B + */ atm =3D 2; - overhead +=3D 19; + overhead +=3D 22; overhead_set =3D true; =20 I assume 30 and 22 are the correct values? Could someone confirm this? :) > qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 dual-s= rchost nat rtt 100.0ms ptm overhead 4502152 > Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 req= ueues 4491152) > backlog 0b 4491256p requeues 4491272 > memory used: 78592b of 4Mb > capacity estimate: 19900Kbit > min/max transport layer size: 4537916 / 4537972 > min/max overhead-adjusted size: 4538000 / 4537972 > average transport hdr offset: 4538072 > > I=E2=80=99m pondering if it=E2=80=99s an endian issue? Are you using the latest kernel code? Those values were added in an incompatible manner, so if you don't have userspace and kernel code in sync they'll be garbage, basically... -Toke