From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C3D673B29E for ; Wed, 21 Sep 2022 05:40:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663753251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vfl/st5m8Se6ltL60JY32xTNgdDLAMTh+1ursFMAnnc=; b=gXQyeF1EBlhM1jMim8Qy5XhtLyfE23+wUQl5qxzjQlV0vFCE9TZHpSuKW9T1GU2mx2klg+ EtwbGyYcBJqcBrovaYqp7z7o27glwD7KF/mrN8Dd9mQC3hRO13kOnT2yLAAQ7wM9E0mcvq OQNygGaCXf7y8IFvgWy/Ro5X/HO0qHk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-INQOPMpiP3ifYaBy5DZJyQ-1; Wed, 21 Sep 2022 05:40:48 -0400 X-MC-Unique: INQOPMpiP3ifYaBy5DZJyQ-1 Received: by mail-ed1-f71.google.com with SMTP id c6-20020a05640227c600b004521382116dso4007910ede.22 for ; Wed, 21 Sep 2022 02:40:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vfl/st5m8Se6ltL60JY32xTNgdDLAMTh+1ursFMAnnc=; b=o8nQFzvMhNtS1IXLzAWMrYAfB91Q/thTqsL4fRRFfKFjhSzY5DgRGm65Q/DwVnHdeT HtuVk+gVvzrWj89uHe3zIar7F7RjiyPKNct05WwDm8fNCarW87HOge3CoSUy+XzYci0x nO58i/YwLPlDTN2abGPVUxE/3AwtegIOIhceM9G1igaLKTWr+fP4Xsxf6KVewpWjDzfQ ZFPiQlzRO7CGVEpN+GZUplxAcr0B58LIUDtkMl/7iJoK+cRKF9dArTzuUurKofOB0wI8 2IYe3ksCqAX9/0Gy50WVTUkdx8kY7uYTLsq3OUhM0Sk15DCi7O73U9amENs5JuQAleHF CBrg== X-Gm-Message-State: ACrzQf1Hh+3CbLjvMHd5szzSTP5EK/1mfOf+ZRC6pinsLfRVp+SvgttY hM7IxvYoshc+hUwTVphjJVl2VQ4J/0SLGWL4AiaAgk+3lUYnUSXQ8P1EdDRHSnN2bHuZOilfCOo SiJrievABBGPrbpTCaYjneg== X-Received: by 2002:a17:907:94ca:b0:77b:542a:4cc4 with SMTP id dn10-20020a17090794ca00b0077b542a4cc4mr19302843ejc.257.1663753247289; Wed, 21 Sep 2022 02:40:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hDKaFsXcDpGvBW7qsS7g0afcmMVDNPrIWCK+FY0bzS4JRPiUwSLUK8z2QrUwdSGY7qf4/BA== X-Received: by 2002:a17:907:94ca:b0:77b:542a:4cc4 with SMTP id dn10-20020a17090794ca00b0077b542a4cc4mr19302826ejc.257.1663753247016; Wed, 21 Sep 2022 02:40:47 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id gj22-20020a170906e11600b0073dd1ac2fc8sm1016556ejb.195.2022.09.21.02.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 02:40:46 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D17D861C4E3; Wed, 21 Sep 2022 11:40:45 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Zhengchao Shao , netdev@vger.kernel.org, cake@lists.bufferbloat.net, linux-kselftest@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vinicius.gomes@intel.com, stephen@networkplumber.org, shuah@kernel.org, victor@mojatatu.com Cc: zhijianx.li@intel.com, weiyongjun1@huawei.com, yuehaibing@huawei.com, shaozhengchao@huawei.com In-Reply-To: <20220921024104.386242-1-shaozhengchao@huawei.com> References: <20220921024104.386242-1-shaozhengchao@huawei.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 21 Sep 2022 11:40:45 +0200 Message-ID: <87illhvzdu.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next, v3 01/18] net/sched: sch_api: add helper for tc qdisc walker stats dump X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 09:40:51 -0000 Zhengchao Shao writes: > The walk implementation of most qdisc class modules is basically the > same. That is, the values of count and skip are checked first. If > count is greater than or equal to skip, the registered fn function is > executed. Otherwise, increase the value of count. So we can reconstruct > them. > > Signed-off-by: Zhengchao Shao Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen