From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH net] sch_cake: Take advantage of skb->hash where appropriate
Date: Fri, 29 May 2020 20:31:45 +0200 [thread overview]
Message-ID: <87imgezj72.fsf@toke.dk> (raw)
In-Reply-To: <20200529105700.73a2b017@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 29 May 2020 14:43:44 +0200 Toke Høiland-Jørgensen wrote:
>> + * enabled there's another check below after doing the conntrack lookup.
>> + */
>
> nit: alignment
Ah, right, seems I forget to hit <TAB> after adding that end marker.
Davem, can I get you to fix that when applying, or should I send a v2?
-Toke
next prev parent reply other threads:[~2020-05-29 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 12:43 Toke Høiland-Jørgensen
2020-05-29 13:02 ` Toke Høiland-Jørgensen
2020-05-29 17:57 ` Jakub Kicinski
2020-05-29 18:31 ` Toke Høiland-Jørgensen [this message]
2020-05-31 4:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imgezj72.fsf@toke.dk \
--to=toke@redhat.com \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox