From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 8CF6A3B2A4 for ; Fri, 29 May 2020 14:31:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590777109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xo3tYPDwFCPRUzBktyt8zxwbMZcTRwPlGKbg3mDhG5g=; b=QBjdakYwdaZC4y2vr9i1CE6fK25L3h7Ec5iezXkoOQDjXyUIIFDOe+2awfr01ZAUi+niBZ WFoLCgiWXovthhVsxkx1+JvWU5QpxJxtspmdRfLa78rZWU4LkjgDV2i/O0j2rg4cMTNw3w KiJgUieKzqSUllFc1Qgj/3RlWfb/abE= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-we5ux99gOAuztkg5GaPmSQ-1; Fri, 29 May 2020 14:31:47 -0400 X-MC-Unique: we5ux99gOAuztkg5GaPmSQ-1 Received: by mail-ed1-f70.google.com with SMTP id dh6so1552781edb.1 for ; Fri, 29 May 2020 11:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Bq/wtvpYAVeNzKGvMSqxNUR+BQj7jca0UzLqrOzrSyc=; b=Pd70oF9wLeh9q/LFUIQQZt25nnOJMkw70aiQUu/RWXvey09cz0i3iS3QIGxyQ30QSn K88uUav0QxNuyjim/fPc5Dk3QB5ecBzXe4aQQt+6clXyo9zfZ/dIBoYlQw2oiG6PKEcc g+kq1O2T3TWtcSRvsvN1Dq9lohaZdl6JNCeGPkRbgwzER2o6va/tu52NS/d9yLpwuXOr YJvaX4q9yXKpmfsecaTu4K/re4b4W9jJiQCsSeli1BY+ojhCymhS36l+SiP4sL3SsjWA D8U2b0W8xKtAUmNeNy3fGk4G2IEignYalvqyeQtGKBqBMwSXxH4xd+YmtnbcbLkOYzip m5aQ== X-Gm-Message-State: AOAM533dbS8KiQv76NoN42bYM7K6gHBXUEJiqApfTdq+8kaarqFC7tdX o/Hk2vwvCvr9sNw9AcWUC0VK0t8Uo8uwJ+UAIAUpB/kQ4HZoYCuBDcCuFIkt6bzeKUJRodJEmAK o3ame2R7Dlt76tHbcwzjjGg== X-Received: by 2002:a17:906:9707:: with SMTP id k7mr9242441ejx.18.1590777106412; Fri, 29 May 2020 11:31:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxieTKkkPtQ0cNgBBbouELGe2iQaqqnrVA5pnq68h7WQkBidqlkxwfZUwkKDtgUzBWHSEO+IQ== X-Received: by 2002:a17:906:9707:: with SMTP id k7mr9242432ejx.18.1590777106258; Fri, 29 May 2020 11:31:46 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id ce23sm4733790edb.79.2020.05.29.11.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 11:31:45 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0F9AF182019; Fri, 29 May 2020 20:31:45 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, cake@lists.bufferbloat.net In-Reply-To: <20200529105700.73a2b017@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> References: <20200529124344.355785-1-toke@redhat.com> <20200529105700.73a2b017@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 29 May 2020 20:31:45 +0200 Message-ID: <87imgezj72.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net] sch_cake: Take advantage of skb->hash where appropriate X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 18:31:49 -0000 Jakub Kicinski writes: > On Fri, 29 May 2020 14:43:44 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >> +=09 * enabled there's another check below after doing the conntrack loo= kup. >> +=09 */ > > nit: alignment Ah, right, seems I forget to hit after adding that end marker. Davem, can I get you to fix that when applying, or should I send a v2? -Toke