From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Adrian Popescu <adriannnpopescu@gmail.com>,
Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Dropping dropped
Date: Thu, 14 Feb 2019 15:35:32 +0100 [thread overview]
Message-ID: <87imxmwi8b.fsf@toke.dk> (raw)
In-Reply-To: <CAF3M4P1pqJkQMG7LOt4cTxpP4Z+SjDrm+4YXpXXaOCHL+rH4Cw@mail.gmail.com>
Adrian Popescu <adriannnpopescu@gmail.com> writes:
> Hello,
>
> I've taken a look at cake's source code to see what simple changes could be
> made to attempt to speed it up. There seemed to be a per flow variable
> called dropped which might not be that useful for regular users. The
> attached patch removes it.
I appreciate the sentiment; however, we keep a lot of statistics for a
reason, and we don't want to just drop those. Besides, a single variable
increment is probably not going to make much difference for performance.
> Perhaps cake could be optimized further for slow devices. What's the
> recommended solution for profiling the kernel on mips with openwrt?
No doubt; however, I'd suggest going about it by actually measuring any
bottle-necks and working from there. The 'perf' tool works on openwrt
these days, I think; that would probably be a good place to start.
-Toke
next prev parent reply other threads:[~2019-02-14 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 14:01 Adrian Popescu
2019-02-14 14:35 ` Toke Høiland-Jørgensen [this message]
2019-02-15 8:23 ` Adrian Popescu
2019-02-15 10:55 ` Toke Høiland-Jørgensen
2019-02-15 20:45 ` Dave Taht
2019-02-16 9:35 ` Adrian Popescu
2019-02-18 20:42 ` Adrian Popescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imxmwi8b.fsf@toke.dk \
--to=toke@redhat.com \
--cc=adriannnpopescu@gmail.com \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox