From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5E0883CB35 for ; Thu, 14 Feb 2019 09:35:35 -0500 (EST) Received: by mail-ed1-f66.google.com with SMTP id 10so5178271eds.7 for ; Thu, 14 Feb 2019 06:35:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=eRWe6Pw+vabbtBE84eqC4F9luVoqNGm+z8EGDSTtXDI=; b=ZBRYJ5dd0+J5u9phR9tsp5y6GhTSZDlPHNE9wJbfpPAy2IDSWIWsgecq1igvj7ng+G /ywoTyNZvGm91v2CahRpW9hialrm4buqWJEEs54AY11h3tUFWbUrAc/exH5UfduDuUzJ J4an0HdRWh9rXyR5jN8Q8rhOBWSaiGcYS/4rqt0+u/hKdMvHh3MpEjpjKBC7+5m+DUVL 23zM8vn/2TjOFeUtzPy6tfcJ0lFsv4moDP9BpmHNonktqGLwc1WpXgy5dnoLdN0zRixQ S9TC0LxHoDi3bQkW67OL1YBaop18aC/BfEUQ+D8xK5DmwpzjXexJTwZoAyv1AXAbO63c 19hg== X-Gm-Message-State: AHQUAua9WKcxBmGpVNeA1VuBnNa2KYgNGM30KKOEecos3K0paYAsae2G idbUipO+UNK8zWleK2QHrpJiTg== X-Google-Smtp-Source: AHgI3Ia1IbHeLgAhc5ll9GEgiCr+NyfSHqrqYTddrQuPqi7FPupxGI8wGwWsVszJdjSfPwsUEHTrJg== X-Received: by 2002:a17:906:ddb:: with SMTP id p27mr3014423eji.162.1550154934429; Thu, 14 Feb 2019 06:35:34 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id j24-v6sm553118ejd.53.2019.02.14.06.35.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 06:35:33 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id AC6521825D9; Thu, 14 Feb 2019 15:35:32 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Adrian Popescu , Cake List In-Reply-To: References: X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 14 Feb 2019 15:35:32 +0100 Message-ID: <87imxmwi8b.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] Dropping dropped X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 14:35:35 -0000 Adrian Popescu writes: > Hello, > > I've taken a look at cake's source code to see what simple changes could be > made to attempt to speed it up. There seemed to be a per flow variable > called dropped which might not be that useful for regular users. The > attached patch removes it. I appreciate the sentiment; however, we keep a lot of statistics for a reason, and we don't want to just drop those. Besides, a single variable increment is probably not going to make much difference for performance. > Perhaps cake could be optimized further for slow devices. What's the > recommended solution for profiling the kernel on mips with openwrt? No doubt; however, I'd suggest going about it by actually measuring any bottle-necks and working from there. The 'perf' tool works on openwrt these days, I think; that would probably be a good place to start. -Toke