From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B34043B29E for ; Sat, 5 Jan 2019 15:11:26 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1546719054; bh=Yn0BnVTZBk+dznEhhsRwfpL7epcVQjWnmFphtxpkM7A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oKydiPoNw1z1V29n4ta1dkv2Y4orqkUgldE3P2wRC9I45D2jy1gzX9Vzih5NGajpt G1rYPpSIzH7AM64Ikoo7rP7XKM16H7IeDPKVoBn4QV2HMy/X2wI/+Rv1FGElCAXbSt XQhtGOgs7oWSSnm/pGdFXOCdsbWiVuNP61OjoLuGTvlkGVQ4CklFogb4eQSkuXpWfg JzPb38k0OS/jQ/a7Srlu8nH+3gkP2xVF5qGDSH9taDgf1mpRzBmMqsJdTNrgLu0Mir 0SePrC+5oMXp0g+O/OJj2ZxN98iTkSdG1RimLHVqsdtKDpCkBTgn130VNuVcn6whUR HMr6USH2kJ9QQ== To: Pete Heist , Sebastian Moeller Cc: Cake List In-Reply-To: References: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> <8736q8yumt.fsf@toke.dk> <4C422792-7E51-4DBA-A229-FA7D3F987FB6@heistp.net> <87zhsgxdao.fsf@toke.dk> <87wonjxvss.fsf@toke.dk> <0077CC34-490F-4D76-82D3-BE37B27F2E1C@heistp.net> <49A6DCF8-BE98-47F4-9C66-6B4288390A58@heistp.net> <87tvinxos7.fsf@toke.dk> <87r2drxnal.fsf@toke.dk> <45D43135-318B-48AD-B09B-69BBB034CE12@heistp.net> <87o98vxm57.fsf@toke.dk> <797FCC60-0048-4EF6-80BC-19707E9173FB@heistp.net> <87lg3zxdyr.fsf@toke.dk> Date: Sat, 05 Jan 2019 21:10:50 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87imz2yiet.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 20:11:26 -0000 Pete Heist writes: > That first bug report looks decidedly similar to mine, but Toke would > have to comment on the specifics. So far I see the patch to > sch_codel.c you mentioned and another two-liner to remove the warning > in hfsc.c (https://patchwork.ozlabs.org/patch/933611/). It would be > really good to know that that warning is truly bogus, that it wasn=E2=80= =99t > put there by the author for good reason, as Toke may have been > thinking of a different way to fix hfsc. Well, it's the same WARN_ON(), and if that patch had been applied, debugging our issue would have been a lot harder, I think. But the underlying issue is different, and we still need to fix HFSC (and probably CAKE as well). > Thanks for bringing this up! I see that I ought to search > OpenWRT/kernel.org next time=E2=80=A6 :) Yeah, nice find. I'll make sure that CAKE doesn't suffer from the same issue that https://www.spinics.net/lists/netdev/msg450655.html fixes for CoDel while I'm writing patches... :) -Toke