Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc
Date: Wed, 25 Apr 2018 20:35:37 +0200	[thread overview]
Message-ID: <87in8f5e2u.fsf@toke.dk> (raw)
In-Reply-To: <c3412b75-156d-3e2c-0f3f-781f2f8bb042@gmail.com>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 04/25/2018 09:17 AM, Toke Høiland-Jørgensen wrote:
>
>> Or am I to interpret that as a hard NAK on having this feature in CAKE
>> (even if we fix the issues you pointed out)?
>
> No strong NACK, as long as the current code is fixed.
>
> Right now, a malicious packet will kill the box or something bad like
> that.

Yeah, that's not good, obviously. I may just pull it out for now and add
it back in a separate patch once we've had time to fix it :)

-Toke

  reply	other threads:[~2018-04-25 18:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 13:42 Toke Høiland-Jørgensen
2018-04-25 13:42 ` [Cake] [PATCH ipruote2-next v4] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-25 14:52 ` [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc Eric Dumazet
2018-04-25 15:22   ` Toke Høiland-Jørgensen
2018-04-25 15:48     ` Eric Dumazet
2018-04-25 15:51     ` Eric Dumazet
2018-04-25 16:06       ` Toke Høiland-Jørgensen
2018-04-25 16:29         ` Eric Dumazet
2018-04-25 16:52           ` Jonathan Morton
2018-04-25 16:57             ` Eric Dumazet
2018-04-25 18:34               ` Toke Høiland-Jørgensen
2018-04-25 18:48                 ` David Miller
2018-04-25 19:02                 ` Eric Dumazet
2018-04-25 19:15                   ` Toke Høiland-Jørgensen
2018-04-25 17:54             ` Sebastian Moeller
2018-04-25 16:55           ` Toke Høiland-Jørgensen
2018-04-25 16:59             ` Eric Dumazet
2018-04-25 16:00     ` Eric Dumazet
2018-04-25 16:17       ` Toke Høiland-Jørgensen
2018-04-25 17:43         ` Eric Dumazet
2018-04-25 18:35           ` Toke Høiland-Jørgensen [this message]
2018-04-25 18:39 ` David Miller
2018-04-25 18:46   ` Toke Høiland-Jørgensen
2018-04-27 10:54 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in8f5e2u.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox