From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3DD1A3BA8E for ; Wed, 25 Apr 2018 14:35:39 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1524681338; bh=F6F8i8qIQuY46p9YortkOfK2/uXTElGW9pQs97vEEv4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=us9hzyi/FhdXI3PWOkw6DBRV5uEN7fRKMypapSamGQ7eFUBZ22t2Y09xvRGfc5Vf+ 3rJP3zEhiPLnPIj9h/kzShkQy3IxwFSaXbqusf3jol0L0N2okLirJcKYEfvm60bIeo 8pGqCy0x7dkTHIWK/xHhxFEO7XyoUIawybHW9/W3qJaNyNinOJI1ObtJZ9FQLAwE5n 5x+pQe6S2Suj4notak/qTEowzTg4zzRLwaloUeI7AsuDRiNIOzQz1m6uPufMjAHMlK YfJJ+68C6smV7T4kbpfV5jbB28PzNdSTyk5BvgdiPb+Fefo8Lb5lxKW12usiocIVM/ wwTrwQACVC/oQ== To: Eric Dumazet , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht In-Reply-To: References: <20180425134249.21300-1-toke@toke.dk> <878t9b5n0q.fsf@toke.dk> <87zi1r5kgx.fsf@toke.dk> Date: Wed, 25 Apr 2018 20:35:37 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87in8f5e2u.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 18:35:39 -0000 Eric Dumazet writes: > On 04/25/2018 09:17 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> Or am I to interpret that as a hard NAK on having this feature in CAKE >> (even if we fix the issues you pointed out)? > > No strong NACK, as long as the current code is fixed. > > Right now, a malicious packet will kill the box or something bad like > that. Yeah, that's not good, obviously. I may just pull it out for now and add it back in a separate patch once we've had time to fix it :) -Toke