From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 17E283CB45 for ; Tue, 6 Mar 2018 06:17:17 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520335036; bh=3hSlIhYEXLCUT/BnKESd1paluTcFME5UgYNoz15rgyo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EfV1vkO7wI/GLyP2/TbWVEv6yqQlF51gxaQgXOrVXVOKsajy5s1uG9yug6gr200tI 8xR2Y/B6VPdB7AYMqZx/qx7MKaau9VAX9VCPJee4KYYWel2WXQdXN36Q2MFJGN901D 3B1pguwfVI3Tl+NBJx1UmleBTk9MXZslRdfVfvB12jeBQIZhMpktuQWOIjTsLrZu5u sbuPfxHNg86kY+X1BH2V1DOQw2wpaH6vu/fp60nNnBq100rVVpup/cRaWlpoOzt8eN W/OJe4JY54erlGUyithXQVK7GMTd+c88mfJH9BryzxyBNjv6AxkHVFSIStcbFcdA64 GSkBiXJVKG4/g== To: Jonathan Morton , Sebastian Moeller Cc: cake@lists.bufferbloat.net In-Reply-To: <08E2549E-769F-4AF3-8D34-22A149432463@gmail.com> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <12C7E818-E440-40A9-AE67-C6EDD7F87FB6@gmx.de> <08E2549E-769F-4AF3-8D34-22A149432463@gmail.com> Date: Tue, 06 Mar 2018 12:17:16 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87ina91mir.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 11:17:18 -0000 Jonathan Morton writes: >> On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote: >> >> BTW, my testing so far with the latest tc-adv did not result in any crashes, but I also did not research whether the overhead account behaves like expected... > > I've just added the relevant stats output. This breaks the stats > struct again (better to do that just after breaking it once, I > suppose), but I left in some padding to reduce the need for that in > future. These stats are kept globally, so are only reported as if for > one tin. Ah yes, the new layout makes it somewhat difficult to add new global stats. I suppose one could store an offset in the struct as well, but that would probably be overdoing it, methinks. A few bytes of padding should work fine; we probably shouldn't keep adding stats forever anyway (famous last words) :) > So far it looks like everything is working fine and behaving as it > should (on a plain Ethernet interface). The one wrinkle is that it > takes a few thousand packets for the avg_off value to converge on the > true value, but that should easily be tolerable in most cases. So, erm, what do the new stats mean? ;) -Toke