From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dave Taht <dave.taht@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
cake@lists.bufferbloat.net, make-wifi-fast@lists.bufferbloat.net,
WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [Cake] WireGuard Queuing, Bufferbloat, Performance, Latency, and related issues
Date: Sat, 01 Oct 2016 19:28:41 +0200 [thread overview]
Message-ID: <87intc9dx2.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw4srSUh+qd8hufuPHmiQHNc4hU0At0r=+SvoB3ccCU4sw@mail.gmail.com> (Dave Taht's message of "Sat, 1 Oct 2016 10:19:00 -0700")
Dave Taht <dave.taht@gmail.com> writes:
> On Sat, Oct 1, 2016 at 8:51 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>> Dave Taht <dave.taht@gmail.com> writes:
>>
>>> My thought - given that at least on some platforms - encrypting 1000
>>> packets at a time is a bad idea - would be something regulating the
>>> amount of data being crypted at a time, an equivalent to byte queue
>>> limits - BQL - BCL? byte crypto limits - to keep no more than, say,
>>> 1ms of data in that part of the subsystem.
>>
>> Well, the dynamic queue limit stuff is reusable (in
>> include/linux/dynamic_queue_limits.h). The netdev BQL stuff just uses
>> these functions with the packet byte sizes; so adapting it to use in
>> wireguard should be fairly straight forward :)
>
> Having one global queue for all of wireguard makes a lot of sense, one
> that gets divvied up as per the amount of traffic for each
> destination,
You'd get that with the FQ structure I described earlier. Then apply the
dql stuff to limit (globally) the number of packets (or bytes) currently
being encrypted, and you should have something fairly reasonable.
-Toke
next prev parent reply other threads:[~2016-10-01 17:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 23:21 Jason A. Donenfeld
2016-10-01 11:51 ` Toke Høiland-Jørgensen
2016-10-01 15:40 ` Dave Taht
2016-10-01 15:51 ` Toke Høiland-Jørgensen
2016-10-01 17:19 ` Dave Taht
2016-10-01 17:28 ` Toke Høiland-Jørgensen [this message]
2016-10-01 22:44 ` Jason A. Donenfeld
2016-10-01 23:40 ` Toke Høiland-Jørgensen
2016-10-02 2:25 ` Jason A. Donenfeld
2016-10-02 2:40 ` Jason A. Donenfeld
2016-10-02 11:31 ` Toke Høiland-Jørgensen
2016-10-05 12:39 ` Jason A. Donenfeld
2016-10-05 13:59 ` Toke Høiland-Jørgensen
2016-10-05 14:21 ` Jonathan Morton
[not found] <CAHmME9pT3wYc=zCm7XcBcgnsT2pDrNWQZpS95+d=GoPPQLa5VQ@mail.gmail.com>
2016-09-30 19:18 ` Dave Taht
2016-09-30 20:12 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87intc9dx2.fsf@toke.dk \
--to=toke@toke.dk \
--cc=Jason@zx2c4.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox