From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; dkim=pass header.d=toke.dk; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=toke.dk policy.dmarc=reject
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
	t=1767777448; bh=sJibSbyiHEkM8f1lwodBlV02zdN7wr4k/0gSXJo4KoY=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=OYyZnfag+BvZ86xIlXCc6s2j0ZU/mwWIDPvaihWNf3NR+WxR/giefkdxvT9Qkecd0
	 fZF957s6y+yZsfPDTK1CmRIDPXxJTzCAPMa4RtJPkpjWKSqRbUOnzN1wza46SUu8Ff
	 wD5I4znXjNmGAzkdo4CmKjs/K99x2v5bDRLql+HPsFMIb2l8VkykiP1zdcLLyVAZ+h
	 Xt7j2j3gxM9GdqvVeILrsEgb9P5gLDjjASk0jnDYVeePAutBqKndp1ONybUCzDTWGz
	 11qqbxOG2dm5V52UlymDAtazwHPixG79eDM7vp71lKAMiEJgY01upwhB08htPodKsY
	 D++NbCT4v2bEA==
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>, Jamal Hadi Salim
 <jhs@mojatatu.com>, Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko
 <jiri@resnulli.us>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: Jonas =?utf-8?Q?K=C3=B6ppeler?= <j.koeppeler@tu-berlin.de>,
 cake@lists.bufferbloat.net,
 netdev@vger.kernel.org
In-Reply-To: <willemdebruijn.kernel.21e0da676fe64@gmail.com>
References: <20260106-mq-cake-sub-qdisc-v6-0-ee2e06b1eb1a@redhat.com>
 <20260106-mq-cake-sub-qdisc-v6-2-ee2e06b1eb1a@redhat.com>
 <willemdebruijn.kernel.21e0da676fe64@gmail.com>
Date: Wed, 07 Jan 2026 10:17:27 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87jyxt4w9k.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Message-ID-Hash: NQ6HPV5YZNVGX6RQZALUDJV6AI2K4DG7
X-Message-ID-Hash: NQ6HPV5YZNVGX6RQZALUDJV6AI2K4DG7
X-MailFrom: toke@toke.dk
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [Cake] Re: [PATCH net-next v6 2/6] net/sched: sch_cake: Factor out config variables into separate struct
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
Archived-At: <https://lists.bufferbloat.net/cake/87jyxt4w9k.fsf@toke.dk/>
List-Archive: <https://lists.bufferbloat.net/cake/>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Owner: <mailto:cake-owner@lists.bufferbloat.net>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Subscribe: <mailto:cake-join@lists.bufferbloat.net>
List-Unsubscribe: <mailto:cake-leave@lists.bufferbloat.net>

Willem de Bruijn <willemdebruijn.kernel@gmail.com> writes:

>>  static int cake_init(struct Qdisc *sch, struct nlattr *opt,
>>  		     struct netlink_ext_ack *extack)
>>  {
>> -	struct cake_sched_data *q = qdisc_priv(sch);
>> +	struct cake_sched_data *qd = qdisc_priv(sch);
>> +	struct cake_sched_config *q;
>>  	int i, j, err;
>>  
>> +	q = kvcalloc(1, sizeof(struct cake_sched_config), GFP_KERNEL);
>> +	if (!q)
>> +		return -ENOMEM;
>> +
>
> Can this just be a regular kzalloc?

Yeah, I guess so. I'll change this if there's a need to respin for other
reasons, but probably not worth respinning for this on its own? Seeing
as it'll all end up in the same kmalloc call anyway :)

> More importantly, where is q assigned to qd->config after init?

Just below:

>>  	sch->limit = 10240;
>>  	sch->flags |= TCQ_F_DEQUEUE_DROPS;
>>  
>> @@ -2742,33 +2755,36 @@ static int cake_init(struct Qdisc *sch, struct nlattr *opt,
>>  			       * for 5 to 10% of interval
>>  			       */
>>  	q->rate_flags |= CAKE_FLAG_SPLIT_GSO;
>> -	q->cur_tin = 0;
>> -	q->cur_flow  = 0;
>> +	qd->cur_tin = 0;
>> +	qd->cur_flow  = 0;
>> +	qd->config = q;

Here:   ^^^^^^^

-Toke