From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=toke.dk; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=toke.dk policy.dmarc=reject From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1764073136; bh=BxJu4QGS4DNMjF5m5xPvxINTbKIPSihKmtj0x6mFxrY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ddV770/Pu6BvI9vPqrOrtD42U2ahxONPBicZH2+qXpTU+B7ahjeBtYv8l/Pk7YMs0 tYjh+r836hVUp3Na50SRcyxpfpKiQ4cIEVz7upz0EgkSiy2Zw74XbOBajqPWGGDUE3 3ubsiN+IOu7wJaYVtgf7Iv2M+vnSERN7RxoBHnAXckpGv/APJ4/WSH8JihxCaMqxms DRWb+8YXcpKqgXfxrxfzNUYnKrdgcNN+xXsYoOgGRNwVZH1JL7QLIfVtHJT+O9rTwX MOuaQdOixG+O3qJ0dTOGpmWTlUb7lUZzT4KSNrHBtPGRvJvSNjpxUt/TiBq5k8iAwT XabPcckLKOLRA== To: David Ahern , Stephen Hemminger Cc: cake@lists.bufferbloat.net, netdev@vger.kernel.org, Jonas =?utf-8?Q?K?= =?utf-8?Q?=C3=B6ppeler?= In-Reply-To: References: <20251124-mq-cake-sub-qdisc-v1-0-a2ff1dab488f@redhat.com> <20251124150350.492522-1-toke@redhat.com> Date: Tue, 25 Nov 2025 13:18:56 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87jyzecnkf.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OM3UKJB25DH4F6ZWBEFX2ZM3Y6FQHLIE X-Message-ID-Hash: OM3UKJB25DH4F6ZWBEFX2ZM3Y6FQHLIE X-MailFrom: toke@toke.dk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH iproute2-next] tc: cake: add cake_mq support List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: David Ahern writes: > On 11/24/25 8:03 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sch= ed.h >> index 15d1a37ac6d8..fb07a8898225 100644 >> --- a/include/uapi/linux/pkt_sched.h >> +++ b/include/uapi/linux/pkt_sched.h >> @@ -1036,6 +1036,7 @@ enum { >> TCA_CAKE_STATS_DROP_NEXT_US, >> TCA_CAKE_STATS_P_DROP, >> TCA_CAKE_STATS_BLUE_TIMER_US, >> + TCA_CAKE_STATS_ACTIVE_QUEUES, >> __TCA_CAKE_STATS_MAX >> }; >> #define TCA_CAKE_STATS_MAX (__TCA_CAKE_STATS_MAX - 1) > > uapi changes should be a separate patch that I can drop when applying. OK, sure. >> diff --git a/tc/q_cake.c b/tc/q_cake.c >> index e2b8de55e5a2..1c143e766888 100644 >> --- a/tc/q_cake.c >> +++ b/tc/q_cake.c >> @@ -525,7 +525,6 @@ static int cake_print_opt(const struct qdisc_util *q= u, FILE *f, struct rtattr *o >> RTA_PAYLOAD(tb[TCA_CAKE_FWMARK]) >=3D sizeof(__u32)) { >> fwmark =3D rta_getattr_u32(tb[TCA_CAKE_FWMARK]); >> } >> - >> if (wash) >> print_string(PRINT_FP, NULL, "wash ", NULL); >> else > > why remove the spacing? whitespace helps readability. That was a mistake that crept in when editing the patch; will put it back :) -Toke