From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A9BDB3CB35 for ; Thu, 28 Feb 2019 04:54:03 -0500 (EST) Received: by mail-lf1-f45.google.com with SMTP id p1so14736081lfk.9 for ; Thu, 28 Feb 2019 01:54:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Sv3AMQIoKY3KGtec8rkpgw/J5LsOSSAOKWXy/lzXNoE=; b=qhk8IGPpinOHIWu1qhkHPqCFozifCcp/ZSPYJz3alGmNLj7uHGY/1CDwqv3/0ndPjs RPsoi71q+t4QjBvY0CX1UFT6NoAsSCEmBFQ7/jUPwMh/foWXBnUfjNAkah22d3VNzC9e hNUy9kyoRpBRlFPlXjiizZPxnhVqkxEY0ptpmkUc4Zah0qvm1s9/w+N5rmm44khbnzC2 qwuV/k5eHfN/aa3xpj3rCHM/uMf99bTEv4ygvlRINjUqjqaG/wWmjqhkLgEDe6cTO2GG 8edkTe2h6zOOQ7/dycyPxsK7rMnhce+J5u/xUrE7YNgrXJfOmTENBkHeTKXEmTFMneLa gKjw== X-Gm-Message-State: AHQUAuao2953AimSMFaj1TSnNz0Tg8NeE/huQuem2vx6gWpquyTNw3YY 0x4Pb3B1UHzMqjkEdaCFBTo0Aj3razn0+Q== X-Google-Smtp-Source: AHgI3IbloMB5nKDrwGcFovW3LNM33QsmPMsbhWNxCJF140VsnX+c+vm0KCPFxavUKiVWXLoKO6JpOw== X-Received: by 2002:a19:f102:: with SMTP id p2mr3158710lfh.29.1551347642401; Thu, 28 Feb 2019 01:54:02 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id o7sm2726351lff.73.2019.02.28.01.54.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 01:54:01 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C53F2183BB9; Thu, 28 Feb 2019 10:54:00 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant Cc: "cake\@lists.bufferbloat.net" In-Reply-To: References: <80982C93-462E-4DE0-B051-E8B30DFCEBFD@darbyshire-bryant.me.uk> <87pnrdmfgn.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 28 Feb 2019 10:54:00 +0100 Message-ID: <87k1hkme6f.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Using firewall connmarks as tin selectors X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 09:54:04 -0000 > I also equally aware that this is =E2=80=98creeping featuritis=E2=80=99 a= nd doing > nothing to speed cake up=E2=80=A6 Yeah, this is the crux of the issue, really: it's a tradeoff between ease of use and featuritis. Now in this case the actual impact is a single check it might actually be acceptable > actually I may have improved BESTEFFORT a little - we no longer look > for matching TC Major numbers if there=E2=80=99s no actual choice of tin = to be > made :-) Well, you made the besteffort case slightly faster, but every other mode slightly slower... :) If you are going to send a patch (or pull request), please leave out the refactoring, and only include the feature. This makes it easier to see the impact of the feature addition on its own. Also, I assume you have a companion patch for iproute2 somewhere? -Toke