Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Georgios Amanakis <gamanakis@gmail.com>,
	Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Fwd:  Compiling under net-next
Date: Mon, 19 Mar 2018 17:52:01 +0100	[thread overview]
Message-ID: <87k1u89ff2.fsf@toke.dk> (raw)
In-Reply-To: <CACvFP_gSCtDaYHdvegMuFumFgYVQLyB4C+yLnKZNe_n1OsMX+Q@mail.gmail.com>

Georgios Amanakis <gamanakis@gmail.com> writes:

>  #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 12, 0)
>      err = nla_parse_nested(tb, TCA_CAKE_MAX, opt, cake_policy);
> -#else
> +#elif LINUX_VERSION_CODE < KERNEL_VERSION(4, 16, 0)
>      err = nla_parse_nested(tb, TCA_CAKE_MAX, opt, cake_policy, NULL);
> +#else
> +    err = nla_parse_nested(tb, TCA_CAKE_MAX, opt, cake_policy, extack);
>  #endif

Yes, exactly!

Could you squash the two patches into one, add a Signed-off-by tag and
send it using git send-email? It's somewhat mangled in transit, it
seems; but otherwise looks good to apply :)

-Toke

  reply	other threads:[~2018-03-19 16:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-18 20:00 [Cake] " Georgios Amanakis
2018-03-19  2:29 ` George Amanakis
2018-03-19 10:16   ` Toke Høiland-Jørgensen
2018-03-19 10:40     ` Toke Høiland-Jørgensen
     [not found]       ` <CACvFP_ijNbkUU8mRCyAwe16qZ=SYMStq=9QiyTBizNhLx-vZtw@mail.gmail.com>
2018-03-19 16:09         ` [Cake] Fwd: " Georgios Amanakis
2018-03-19 16:52           ` Toke Høiland-Jørgensen [this message]
2018-03-19 17:11             ` [Cake] [PATCH] Fixes for 4.16 George Amanakis
2018-03-20  9:33               ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1u89ff2.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=gamanakis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox