From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 09A623CB4D
 for <cake@lists.bufferbloat.net>; Wed,  7 Mar 2018 06:31:26 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1520422285; bh=5c7uD2bTw+pU6CNptJjsFdLBe3XsHr5OmVsdIf84qV0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=fyouq1a5gytN8yWig0PVHzUSvTGReYKFrTT2WQ7kIffotcWGO3blDXjvvfaz6w4VX
 eCsyILxFi52X77w7qmDzgHO7fkozz9D3sjcq0srY2eW+5nj/7tTFgVjerRkKTDmz4R
 o9OCeB4Wz6ZM0DvcHLWvReb4V1vywVGDDAVJgIUVZJxatEv9GNFqnrdckd6Ywr19Du
 2blwjMsRDw4HHbaTN6/nN6do+blfT3a7woVqhaoL0biQIKwb7NPhOs+If+CoT6/mjz
 SRYZXBG9t4I1JmpVoBC2e6rKiWWBaLCYFGBXy3HPg4UV1wGs8PgAageYsei6WvIY7I
 DXD/GzISwzdCQ==
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: Jonathan Morton <chromatix99@gmail.com>,
 "cake\@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
In-Reply-To: <51840D7A-D83F-4A9B-86BE-49C65105B82F@darbyshire-bryant.me.uk>
References: <20180127130542.25817-1-toke@toke.dk>
 <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk>
 <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk>
 <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com>
 <87sh9cl15n.fsf@toke.dk>
 <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk>
 <87vae8yy68.fsf@toke.dk>
 <51840D7A-D83F-4A9B-86BE-49C65105B82F@darbyshire-bryant.me.uk>
Date: Wed, 07 Mar 2018 12:31:24 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87k1uoyveb.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin
	structure
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 11:31:26 -0000

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

>> On 7 Mar 2018, at 10:31, Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>=
 wrote:
>>=20
>>>=20
>>=20
>> Please don't put something different into LEDE than what we're working
>> on upstreaming. It is difficult enough to keep track of the different
>> versions as they are. The tc-adv repo is already rebased on the upstream
>> iproute2-next, so if there is anything else that needs to be changed, it
>> should be changed in that repo and not in a fork...
>>=20
>> -Toke
>
> Received & understood.  Not sending to lede=E2=80=A6 probably a good idea
> anyway as the main stats (not tin stats) are broken for me.  I wonder
> if this is because q_cake has to be imported to lede as a patch
> applied on top of whatever iproute2 version they=E2=80=99re using as the =
base?

As far as I can tell, the iproute2 version in openwrt is currently
4.15.0; which means that once we get this sorted out, it *should* be
straight forward to create a new patch that applies cleanly. I can do
that while preparing the upstream submission; but want to make sure we
have everything included without any version divergence first...

-Toke