From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 476A63CB39
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 17:16:39 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1526505398; bh=cjtnn8BANLvutcQdcfLxFsShTmCw7mLPHwVTww7zjSc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=pE+JAxzAUYxHHBL3kpMEJuM+3U1+KTl2L4XheCD50dRLgPqjuSEtbXr8FxIwmftLV
 JDu+jDi2NJ5gI+KcxrGnYiThQYnwoS+gAJPGr6XHu+qA0QfAMp1JOR2RU4B9sxzib5
 Q2dw/d+e6ZFcphPxx1R1mfYZd3XRpao6ieQ5QHIEOybNf/8O2gHsu/zt2n1LoztEL0
 X1fluaqeMdPYmglz61JmxO4CWgSxTNYXRUnqxu99Ea9UGGC86R9I/IPzMXKGhJR21D
 Mc4sAimG/BShaGXKLWwSkRz4Vg62fE0bQ0cRuQdi26wKPuzyRwyi6/Lnawju5IqHCH
 suyJ3f9K2tAdQ==
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
In-Reply-To: <CAM_iQpVz9bRDkW_cqj-vo6fapXaG6zV-bWM0Sc2wmHuj-vzWqg@mail.gmail.com>
References: <152650253056.25701.10138252969621361651.stgit@alrua-kau>
 <152650254608.25701.5749607607862123240.stgit@alrua-kau>
 <CAM_iQpVz9bRDkW_cqj-vo6fapXaG6zV-bWM0Sc2wmHuj-vzWqg@mail.gmail.com>
Date: Wed, 16 May 2018 23:16:32 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87lgcjuwr3.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v12 2/7] sch_cake: Add ingress mode
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 21:16:39 -0000

Cong Wang <xiyou.wangcong@gmail.com> writes:

> On Wed, May 16, 2018 at 1:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen <toke@t=
oke.dk> wrote:
>> +       if (tb[TCA_CAKE_AUTORATE]) {
>> +               if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE]))
>> +                       q->rate_flags |=3D CAKE_FLAG_AUTORATE_INGRESS;
>> +               else
>> +                       q->rate_flags &=3D ~CAKE_FLAG_AUTORATE_INGRESS;
>> +       }
>> +
>> +       if (tb[TCA_CAKE_INGRESS]) {
>> +               if (!!nla_get_u32(tb[TCA_CAKE_INGRESS]))
>> +                       q->rate_flags |=3D CAKE_FLAG_INGRESS;
>> +               else
>> +                       q->rate_flags &=3D ~CAKE_FLAG_INGRESS;
>> +       }
>> +
>>         if (tb[TCA_CAKE_MEMORY])
>>                 q->buffer_config_limit =3D nla_get_u32(tb[TCA_CAKE_MEMOR=
Y]);
>>
>> @@ -1559,6 +1628,14 @@ static int cake_dump(struct Qdisc *sch, struct sk=
_buff *skb)
>>         if (nla_put_u32(skb, TCA_CAKE_MEMORY, q->buffer_config_limit))
>>                 goto nla_put_failure;
>>
>> +       if (nla_put_u32(skb, TCA_CAKE_AUTORATE,
>> +                       !!(q->rate_flags & CAKE_FLAG_AUTORATE_INGRESS)))
>> +               goto nla_put_failure;
>> +
>> +       if (nla_put_u32(skb, TCA_CAKE_INGRESS,
>> +                       !!(q->rate_flags & CAKE_FLAG_INGRESS)))
>> +               goto nla_put_failure;
>> +
>
> Why do you want to dump each bit of the rate_flags separately rather than
> dumping the whole rate_flags as an integer?

Well, these were added one at a time, each as a new option. Isn't that
more or less congruent with how netlink attributes are supposed to be
used?

-Toke