From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.taht.net (mail.taht.net [IPv6:2a01:7e00::f03c:91ff:feae:7028]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 44FE03B2A4 for ; Tue, 21 Nov 2017 14:05:08 -0500 (EST) Received: from nemesis.taht.net (unknown [IPv6:2603:3024:1536:86f0:2e0:4cff:fec1:1206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id 1DAC221341; Tue, 21 Nov 2017 19:05:06 +0000 (UTC) From: Dave Taht To: Jonathan Morton Cc: cake@lists.bufferbloat.net References: <1510945885-9986-1-git-send-email-dave.taht@gmail.com> <1510945885-9986-3-git-send-email-dave.taht@gmail.com> <8760a81y3s.fsf@nemesis.taht.net> Date: Tue, 21 Nov 2017 11:05:05 -0800 In-Reply-To: (Jonathan Morton's message of "Tue, 21 Nov 2017 00:22:56 +0200") Message-ID: <87lgiztpum.fsf@nemesis.taht.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] [RFC PATCH 2/3] Add cake related includes and source files X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 19:05:08 -0000 Jonathan Morton writes: > On 17/11/17 21:52, Dave Taht wrote: >> I think if (!drop && var->p_drop) would be more effecient here. > > But it is 'p_drop' that is more likely to be zero in practice. The BLUE logic > rarely activates. ok.