From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 14AFE3CB35 for ; Fri, 3 May 2019 11:13:17 -0400 (EDT) Received: by mail-ed1-f66.google.com with SMTP id f37so6378949edb.13 for ; Fri, 03 May 2019 08:13:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=9OB5U01gE0ihNsPhnI3xLxXzVR37gKG4V5jFCcPh4Rc=; b=FnvLncSCreEEtJEHNzQaf+odwR5RobNASeVnskcq4flfysHTXSmS5Bt4Wwsc9OZeD2 DAtX9HYVLbGIQuzVvKgPhUj96VzcV0Hqq7L7V0LUVM4MrVSUJ7B6xMwAqmxnUmNGtnbM RP+vhEhRBYNF7JUeGGEzd7IIHxjMHLIw5kggGQe+WkP7S2q/yYWfX/jROzAmAAMLmf8H Pt9Y/ui+t5niBa3hmNWFMeyoK3iAR77m2Ho31rzyW7mq6ZuY+hZoGElyFiaj5jP1LLT1 JtmaSxZ41x/gZvpCFkGIW+Gfhpdo2V/eKHFeMOC632yqdeFEavIKaHd8DxcwRqFmnbA5 Pxsw== X-Gm-Message-State: APjAAAUN+py9Uh10UvsjVNhy+TKuNLv500MmmNvmU8ZrCR6+LKg9k8eS Hi6G8E65mNLFpE3jNuXHHxISae/XFhA= X-Google-Smtp-Source: APXvYqyBbChY55so8d5IEG4c5pNU5fLocf3x7Ibmr88wZfozRvC1RLONDux6/uxB2cZ9Q6JQS7CSgA== X-Received: by 2002:a50:bd85:: with SMTP id y5mr9092470edh.112.1556896395896; Fri, 03 May 2019 08:13:15 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id t29sm642377edb.30.2019.05.03.08.13.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 08:13:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8ED821800E2; Fri, 3 May 2019 17:13:14 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant Cc: Cake List In-Reply-To: <96D6EC2B-C57B-450D-AC65-9D9526840D83@darbyshire-bryant.me.uk> References: <493B2B95-93C5-4CEB-906E-CFF0BF3187E9@darbyshire-bryant.me.uk> <87pnozhb2s.fsf@toke.dk> <96D6EC2B-C57B-450D-AC65-9D9526840D83@darbyshire-bryant.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 03 May 2019 17:13:14 +0200 Message-ID: <87muk3h8qd.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Possible conntrack lookup improvements X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 15:13:17 -0000 Kevin Darbyshire-Bryant writes: >> On 3 May 2019, at 15:22, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >> Kevin Darbyshire-Bryant writes: >>=20 >>> Hi Everyone, >>>=20 >>> I=E2=80=99ve been working on act_ctinfo toward getting that upstream an= d it is >>> getting closer. Since that module along with act_connmark does its own >>> conntrack lookups I=E2=80=99ve been looking at what they do and what we= do in >>> cake. >>>=20 >>> Two patches attached - one is a simple variable elimination with no >>> functional change. The second changes/simplifies the conntrack tuple >>> lookup & usage. I=E2=80=99ve had a play and I don=E2=80=99t think I=E2= =80=99ve broken any of >>> the host fairness BUT it could do with some more testing, that=E2=80=99= s where >>> you come in=E2=80=A6 probably Pete & George :-) >>=20 >> Seems reasonable. But please fold these two patches into one; changing >> everything, then immediately changing it again does not help >> readability... And the explanation makes a lot more sense if you just >> change the whole thing in one patch :) >>=20 >> -Toke > > Yeah, when I do the PR after testing confirms I haven=E2=80=99t totally > screwed up host fairness in the process I=E2=80=99ll of course squash them > together :-) Cool :) -Toke