From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id BB6693CB39
 for <cake@lists.bufferbloat.net>; Sat, 17 Mar 2018 10:34:12 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1521297251; bh=se0mylREoH+dTYsnxd4dlvci3Pjor7d3S+8c7PxMs6E=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=uEKHjNA2AS+uEUmHWAGq5+oLXMSrphmb3yfBksDZnXstO3/h6VZ0FzS+PP14//HF1
 HWIT/bYVlokJYMC69/tumU3jhGK5EszEFpfShKp1HEKCksvvo3ieiGn1o5AVqVAjCG
 buaKvpkgwDI1FrasW17ucxLxsbp/8vn+YtWXQP4Lpk+Lr8MtVR5OKthp9cD9Ck5mQ2
 ns8eaChVJjePInpeFTrsIgsKiFJR+sXVwl09O+lURlXpvyKUrZYLxHZI4sKba7xJ+V
 h0AGYf9d5i9d/C6FC2wMI6dF1jAJhDSJWAOWJLuvdlyCLyUZJkUwqUr3Hc3i7FmUf9
 /Q29PYFrMjd0Q==
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>,
 Stephen Hemminger <stephen@networkplumber.org>
Cc: "cake\@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
In-Reply-To: <6DC9DE5E-0ED4-4BBB-9C7C-0F8887856D25@darbyshire-bryant.me.uk>
References: <20180311091930.86264-1-ldir@darbyshire-bryant.me.uk>
 <20180311091930.86264-2-ldir@darbyshire-bryant.me.uk>
 <87bmfujq18.fsf@toke.dk>
 <5DD63A68-EE32-4A5C-B08E-019FB8CBC9B1@darbyshire-bryant.me.uk>
 <20180311163423.2e8d63b6@xeon-e3>
 <B6C5D3BD-4DC9-4B63-BB48-24C9AA05DA59@darbyshire-bryant.me.uk>
 <874lllk47a.fsf@toke.dk> <20180312081142.0a9da85c@xeon-e3>
 <6DC9DE5E-0ED4-4BBB-9C7C-0F8887856D25@darbyshire-bryant.me.uk>
Date: Sat, 17 Mar 2018 15:33:43 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87o9jmdb5k.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH 1/2] cake: print_uint format fixes
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 17 Mar 2018 14:34:12 -0000

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

>> On 12 Mar 2018, at 15:11, Stephen Hemminger <stephen@networkplumber.org>=
 wrote:
>>=20
>> On Mon, 12 Mar 2018 10:56:09 +0100
>> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
>>>=20
>>> Stephen, would you accept patches to fix the API (to add
>>> print_{u,}int64() variants and turn print_uint() into native-int size)?
>>> Or should we stick with the API currently there and live with the
>>> inconsistency? :)
>>>=20
>>> -Toke
>>=20
>> I agree print_int should take int, print_uint should take unsigned int, =
and there should
>> be print_u64 (and print_u32, print_u8)
>
> Submitted a patch to netdev but almost certainly did it wrong/based on
> wrong tree etc =E2=80=98cos I don=E2=80=99t normally inhabit that space. =
The quite
> simple attached patch restores corrrect functioning on my BE MIPS box.
> Validation that the MANY calls to print_uint are using the correct
> type is left as an exercise for the reader :-) But at least there=E2=80=
=99s no
> longer a hidden promotion from uint to uint_64t going on.

Awesome! Good work :)

-Toke