Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: cake@lists.bufferbloat.net
Subject: [Cake] Correct 'change' behaviour
Date: Tue, 03 Nov 2015 13:59:44 +0100	[thread overview]
Message-ID: <87oafbnsqn.fsf@toke.dk> (raw)

So we've seen a couple of issues with reconfiguration being weird (i.e.
retaining previous values). Looking at the code in cake_change() and the
iproute2 code, this seems to stem from the fact that tc only sets the
parameters (in the netlink message) that are actually specified on the
command line, and the kernel only changes the parameters specified in
the netlink message.

This leads to the different behaviour: On init, not specifying a
parameter means "give me a sensible default", whereas on a reconfigure
it means "don't change this parameter from its current value". This is
obviously inconsistent. I'd argue that the right thing to do is the
former in all cases; is there any reason why that would not be the case?
If not, I'll go fix it :)

-Toke

             reply	other threads:[~2015-11-03 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 12:59 Toke Høiland-Jørgensen [this message]
2015-11-03 13:11 ` Kevin Darbyshire-Bryant
2015-11-03 13:14   ` Toke Høiland-Jørgensen
2015-11-03 17:24     ` Jonathan Morton
     [not found]       ` <87oafbat54.fsf@toke.dk>
2015-11-03 17:32         ` Jonathan Morton
2015-11-03 17:51           ` Toke Høiland-Jørgensen
2015-11-03 19:07             ` Toke Høiland-Jørgensen
2015-11-03 19:14               ` Dave Taht
2015-11-04 11:09                 ` Toke Høiland-Jørgensen
2015-11-04 14:28                   ` Sebastian Moeller
2015-11-04 18:04                   ` Kevin Darbyshire-Bryant
2015-11-04 18:51                     ` Toke Høiland-Jørgensen
2015-11-04 18:55                       ` Sebastian Moeller
2015-11-03 17:54     ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oafbnsqn.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox