From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.taht.net (mail.taht.net [IPv6:2a01:7e00::f03c:91ff:feae:7028]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 141B63CB35; Wed, 21 Aug 2019 12:52:57 -0400 (EDT) Received: from dancer.taht.net (unknown [IPv6:2603:3024:1536:86f0:eea8:6bff:fefe:9a2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id 79DCD21425; Wed, 21 Aug 2019 16:52:55 +0000 (UTC) From: Dave Taht To: Kevin Darbyshire-Bryant Cc: Dave Taht , Cake List , cerowrt-devel References: <30EA2270-684E-48BC-8B57-43F4D8485BE8@darbyshire-bryant.me.uk> Date: Wed, 21 Aug 2019 09:52:43 -0700 In-Reply-To: <30EA2270-684E-48BC-8B57-43F4D8485BE8@darbyshire-bryant.me.uk> (Kevin Darbyshire-Bryant's message of "Wed, 21 Aug 2019 16:38:36 +0000") Message-ID: <87pnkyea04.fsf@taht.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [Cerowrt-devel] https://tools.ietf.org/html/draft-ietf-tsvwg-le-phb-06 is in last call X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2019 16:52:57 -0000 Kevin Darbyshire-Bryant writes: > Maybe attached patch is more comprehensive? Yep! why was diffserv8 5 in the first place? > > KDB > >> On 21 Aug 2019, at 16:07, Dave Taht wrote: >>=20 >> Just ressurrecting this old thread for review now that this is an >> official RFC. I note also that the NQB diffserv codepoint is entering >> last call also. >>=20 >> https://tools.ietf.org/html/draft-white-tsvwg-nqb-02 >>=20 >> On Sun, Feb 3, 2019 at 10:39 AM Dave Taht wrote: >>>=20 >>> And seems likely to be adopted. >>>=20 >>> There seems to be an urge to make this codepoint starvable, which >>> since I ascribe to nagle's dictum "every application has a right to >>> one packet in the network" - doesn't work for me - but the draft is >>> vaguely worded enough to just start dumping this codepoint into the >>> background queue of both sqm and cake and worry about it in a decade >>> or three. >>>=20 >>> it's 000001 which I guess is: >>>=20 >>> diff --git a/sch_cake.c b/sch_cake.c >>> index 3a26db0..67263b3 100644 >>> --- a/sch_cake.c >>> +++ b/sch_cake.c >>> @@ -343,7 +343,7 @@ static const u8 diffserv4[] =3D { >>> }; >>>=20 >>> static const u8 diffserv3[] =3D { >>> - 0, 0, 0, 0, 2, 0, 0, 0, >>> + 0, 1, 0, 0, 2, 0, 0, 0, >>> 1, 0, 0, 0, 0, 0, 0, 0, >>> 0, 0, 0, 0, 0, 0, 0, 0, >>> 0, 0, 0, 0, 0, 0, 0, 0, >>>=20 >>> (or is that reversed? my big endian/little endian chops scuks, and >>> nobody modified the gen_cake_const tool to match what cake expects >>> now) >>>=20 >>> on my off days I kind of wish the diffserv lookup we do in cake had >>> managed to make it into the linux mqprio/prio stuff by default. >>>=20 >>> -- >>>=20 >>> Dave T=C3=A4ht >>> CTO, TekLibre, LLC >>> http://www.teklibre.com >>> Tel: 1-831-205-9740 >>=20 >>=20 >>=20 >> -- >>=20 >> Dave T=C3=A4ht >> CTO, TekLibre, LLC >> http://www.teklibre.com >> Tel: 1-831-205-9740 >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake > > > Cheers, > > Kevin D-B > > gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > > From 1f460443d1bd54d269e3efda6999c0bbd91f7a03 Mon Sep 17 00:00:00 2001 > From: Kevin Darbyshire-Bryant > Date: Mon, 4 Feb 2019 21:27:58 +0000 > Subject: [PATCH] RFC 8622 diffserv3, 4 & 8 LE PHB support > > Change tin mapping on diffserv3, 4 & 8 for LE PHB support, > in essence make LE a member of the Bulk tin. > > Bulk has the least priority and minimum of 1/16th total bandwidth in the > face of higher priority traffic. > > NB: Diffserv 3 & 4 swap tin 0 & 1 priorities from the default order as > found in diffserv8, in case anyone is wondering why it looks a bit odd. > > Signed-off-by: Kevin Darbyshire-Bryant > --- > sch_cake.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sch_cake.c b/sch_cake.c > index 93c0c8a..81950ad 100644 > --- a/sch_cake.c > +++ b/sch_cake.c > @@ -333,8 +333,8 @@ static const u8 precedence[] =3D { > }; >=20=20 > static const u8 diffserv8[] =3D { > - 2, 5, 1, 2, 4, 2, 2, 2, > - 0, 2, 1, 2, 1, 2, 1, 2, > + 2, 0, 1, 2, 4, 2, 2, 2, > + 1, 2, 1, 2, 1, 2, 1, 2, > 5, 2, 4, 2, 4, 2, 4, 2, > 3, 2, 3, 2, 3, 2, 3, 2, > 6, 2, 3, 2, 3, 2, 3, 2, > @@ -344,7 +344,7 @@ static const u8 diffserv8[] =3D { > }; >=20=20 > static const u8 diffserv4[] =3D { > - 0, 2, 0, 0, 2, 0, 0, 0, > + 0, 1, 0, 0, 2, 0, 0, 0, > 1, 0, 0, 0, 0, 0, 0, 0, > 2, 0, 2, 0, 2, 0, 2, 0, > 2, 0, 2, 0, 2, 0, 2, 0, > @@ -355,7 +355,7 @@ static const u8 diffserv4[] =3D { > }; >=20=20 > static const u8 diffserv3[] =3D { > - 0, 0, 0, 0, 2, 0, 0, 0, > + 0, 1, 0, 0, 2, 0, 0, 0, > 1, 0, 0, 0, 0, 0, 0, 0, > 0, 0, 0, 0, 0, 0, 0, 0, > 0, 0, 0, 0, 0, 0, 0, 0,