From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>,
Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Possible conntrack lookup improvements
Date: Fri, 03 May 2019 16:22:35 +0200 [thread overview]
Message-ID: <87pnozhb2s.fsf@toke.dk> (raw)
In-Reply-To: <493B2B95-93C5-4CEB-906E-CFF0BF3187E9@darbyshire-bryant.me.uk>
Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
> Hi Everyone,
>
> I’ve been working on act_ctinfo toward getting that upstream and it is
> getting closer. Since that module along with act_connmark does its own
> conntrack lookups I’ve been looking at what they do and what we do in
> cake.
>
> Two patches attached - one is a simple variable elimination with no
> functional change. The second changes/simplifies the conntrack tuple
> lookup & usage. I’ve had a play and I don’t think I’ve broken any of
> the host fairness BUT it could do with some more testing, that’s where
> you come in… probably Pete & George :-)
Seems reasonable. But please fold these two patches into one; changing
everything, then immediately changing it again does not help
readability... And the explanation makes a lot more sense if you just
change the whole thing in one patch :)
-Toke
next prev parent reply other threads:[~2019-05-03 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 13:55 Kevin Darbyshire-Bryant
2019-05-03 14:16 ` Jonathan Morton
2019-05-03 18:57 ` Kevin Darbyshire-Bryant
2019-05-03 19:13 ` Toke Høiland-Jørgensen
2019-05-03 19:23 ` Kevin Darbyshire-Bryant
2019-05-03 23:57 ` Kevin Darbyshire-Bryant
2019-05-03 14:22 ` Toke Høiland-Jørgensen [this message]
2019-05-03 14:32 ` Kevin Darbyshire-Bryant
2019-05-03 15:13 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnozhb2s.fsf@toke.dk \
--to=toke@redhat.com \
--cc=cake@lists.bufferbloat.net \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox