From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B3CD93CB35 for ; Fri, 3 May 2019 10:22:37 -0400 (EDT) Received: by mail-ed1-f67.google.com with SMTP id w33so3876481edb.10 for ; Fri, 03 May 2019 07:22:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=MbhCg2VJsNT0tGKgfXjxg1F6/FbhcHMNiUg23qvLW8U=; b=cK1sCYh+OEkWasNA6SrWgkdcDoHh83+f1ApQKNWyF+NN0er11Uql7hQXfjcLc5XUC/ LU7b1QlFXqxy4LJC6pqSact1Hf6ak/W5w/9gIRM6hx+v8Zqk2OM3l+Z15/tLtBpgFRDC WtVzHxFf9ephVe8Fw8XUBjPpK7IInMcLRQBH0T8IoU2oYIJIYF95TXbrT5ksPZ5VuQyx I0wnk8/8TjdB0UoJQJJxTVnLyD4mFLTpkJBPOP7dWEGqBOg1YsxEU8Nu+7QiJtO+Y3gA SH4nCxrQ4fWNI+B/RzZFfN+3o6V6z4CB6NnQMHDZ5oPSBRnlxg+RsOCWJgp688ptB2ao Yz2Q== X-Gm-Message-State: APjAAAVFLf4DRVFqf3/Or79NiEJrbRjG3qZAZmZkukXclWX3eHywljqZ zbn1uF272LSmokYb9r3bV38BFeoIV3I= X-Google-Smtp-Source: APXvYqw0C+uTzwBnxUI0q1zl/BiyCtJ7vW7cEun0uuEN0VbzAii+OYHmcGpriM/eo6GoSuMcRBxB3w== X-Received: by 2002:a17:906:b7da:: with SMTP id fy26mr3800022ejb.148.1556893356796; Fri, 03 May 2019 07:22:36 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id b42sm583748edd.83.2019.05.03.07.22.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 07:22:36 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C0E091800E2; Fri, 3 May 2019 16:22:35 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant , Cake List In-Reply-To: <493B2B95-93C5-4CEB-906E-CFF0BF3187E9@darbyshire-bryant.me.uk> References: <493B2B95-93C5-4CEB-906E-CFF0BF3187E9@darbyshire-bryant.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 03 May 2019 16:22:35 +0200 Message-ID: <87pnozhb2s.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Possible conntrack lookup improvements X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 14:22:37 -0000 Kevin Darbyshire-Bryant writes: > Hi Everyone, > > I=E2=80=99ve been working on act_ctinfo toward getting that upstream and = it is > getting closer. Since that module along with act_connmark does its own > conntrack lookups I=E2=80=99ve been looking at what they do and what we d= o in > cake. > > Two patches attached - one is a simple variable elimination with no > functional change. The second changes/simplifies the conntrack tuple > lookup & usage. I=E2=80=99ve had a play and I don=E2=80=99t think I=E2=80= =99ve broken any of > the host fairness BUT it could do with some more testing, that=E2=80=99s = where > you come in=E2=80=A6 probably Pete & George :-) Seems reasonable. But please fold these two patches into one; changing everything, then immediately changing it again does not help readability... And the explanation makes a lot more sense if you just change the whole thing in one patch :) -Toke