From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 292153CB35 for ; Wed, 27 Feb 2019 10:14:03 -0500 (EST) Received: by mail-ed1-f53.google.com with SMTP id b20so14160336edw.11 for ; Wed, 27 Feb 2019 07:14:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=v8GWKTT/eNLFt5E5F0punlJFoW7gAe0McO8KF1smig8=; b=TwgB7cvAq6sDl3nwZ94wJ6G+rH+ecEwJCYiB7jVGlhJ6I6U4yiMooteVs6CPuLKHFF HyiR0MkmkjZw1zNKpMA+h/2u1q+i/zI5SDg6fLyfVeUBDgjdFgm1ZktDkYTiX3q+/nl5 D00dSOAA4288L5sxDZyWh8s2aG71JOcqPPz2Rym4ii40z6cDVezRokKBichB0b8hLXE4 ysor0wa7kCdlZW5PaamJnyX6nbJ66lyix5+wj6Pyx51niXCdt3dli20SQ23YuOsE6bvF qoVFOSi8TWvzFTMy+HEL9qCplGnUamdK1Q7sJOQjfxUzFU1llGfcrNIB1Y6rORMr9/rK xGGA== X-Gm-Message-State: AHQUAuZ+TU6CVINFLRPVhEd1Tb1BIX3bMkQMcH4SJdrZo3W4OWSoaU0k gu+NiDGC70DAxyiC6hhzjl1tiQ== X-Google-Smtp-Source: AHgI3IZAY7p0YnSQuXfReyvqcrUkWoYM6vLUolCYfEt79t2Q2zl3lX9289oqt4TBasidDTdlcsCv1w== X-Received: by 2002:a17:906:f87:: with SMTP id q7mr1901194ejj.237.1551280442200; Wed, 27 Feb 2019 07:14:02 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id p7-v6sm2711801ejf.64.2019.02.27.07.14.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 07:14:01 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E2387183BB9; Wed, 27 Feb 2019 16:14:00 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kevin Darbyshire-Bryant , "cake\@lists.bufferbloat.net" In-Reply-To: <80982C93-462E-4DE0-B051-E8B30DFCEBFD@darbyshire-bryant.me.uk> References: <80982C93-462E-4DE0-B051-E8B30DFCEBFD@darbyshire-bryant.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 27 Feb 2019 16:14:00 +0100 Message-ID: <87pnrdmfgn.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Using firewall connmarks as tin selectors X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 15:14:03 -0000 Kevin Darbyshire-Bryant writes: > How unpopular would the idea of having cake look at skb->mark directly be? > > https://github.com/ldir-EDB0/sch_cake/commit/64d0e6ac9368a271221db888ab91= a367fcd37ae1 > > https://github.com/ldir-EDB0/tc-adv/commit/4f16ae5d588d44f8a5c83fe2f2b7dc= ad97843cbc Hmm, not impossible, but seeing as we already have a way to achieve that with BPF, is it really needed? > I did the equivalent in eBPF here > https://github.com/ldir-EDB0/cls_bpf_connmark_to_caketin but I can=E2=80= =99t > work out how to make the major number a tc command line argument into > the BPF code. You can't, but you can set the major number explicitly when you create the qdisc: $ sudo tc qdisc replace dev eth0 root handle 1: cake $ tc qdisc show dev eth0 qdisc cake 1: root refcnt 2 bandwidth unlimited diffserv3 triple-isolate no= nat nowash no-ack-filter split-gso rtt 100.0ms raw overhead 0 -Toke