From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc
Date: Wed, 09 Jan 2019 09:37:33 +0100 [thread overview]
Message-ID: <87pnt6teeq.fsf@toke.dk> (raw)
In-Reply-To: <20190108.133053.2049686690825668341.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
> From: Toke Høiland-Jørgensen <toke@toke.dk>
> Date: Mon, 7 Jan 2019 20:47:29 +0100
>
>> This series fixes a couple of issues exposed by running sch_cake as a
>> leaf qdisc in an HFSC tree, which were discovered and reported by Pete
>> Heist. The interaction between CAKE's GSO splitting and the parent
>> qdisc's notion of its own queue length could cause queue stalls. While
>> investigating the report, I also noticed that several qdiscs would
>> dereference the skb pointer after dequeue, which is potentially
>> problematic since the GSO splitting code also frees the original skb.
>>
>> See the individual patches in the series for details.
>
> Toke, can you please resubmit this without patch #3.
>
> If you want to push for patch #3 still, it is much easier to submit
> it separately.
Can do :)
-Toke
prev parent reply other threads:[~2019-01-09 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:47 Toke Høiland-Jørgensen
2019-01-07 19:47 ` [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue Toke Høiland-Jørgensen
2019-01-09 1:38 ` Cong Wang
2019-01-09 8:14 ` Toke Høiland-Jørgensen
2019-01-10 18:16 ` Cong Wang
2019-01-07 19:47 ` [Cake] [PATCH 2/4] sched: Fix detection of empty queues in child qdiscs Toke Høiland-Jørgensen
2019-01-07 19:57 ` Dave Taht
2019-01-07 19:47 ` [Cake] [PATCH 3/4] sch_api: Allow reducing queue backlog by a negative value Toke Høiland-Jørgensen
2019-01-07 20:54 ` Eric Dumazet
2019-01-08 9:55 ` Toke Høiland-Jørgensen
2019-01-07 19:47 ` [Cake] [PATCH 4/4] sch_cake: Correctly update parent qlen when splitting GSO packets Toke Høiland-Jørgensen
2019-01-08 21:30 ` [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc David Miller
2019-01-09 8:37 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnt6teeq.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox