From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 58FBD3B29E
 for <cake@lists.bufferbloat.net>; Wed,  9 Jan 2019 03:37:38 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1547023057; bh=3w1aDr9mg2OiyV4nARPbxf9WuRbDgctmsXgb4uJCRAg=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=lsKpaZK2EJmwdWgovyRl9w1rfokWfEltT019ldpIPR97W7suEGX/tA/U0N3LWopa2
 LH6fdVz2IEWkiSqfMBR4Ic9VFYQQFTlSmZsBjU05KnqWmSl2PI09keoAQ45MfwCjsV
 4el2OTNF8hkIbiwdLjWqm/ZH2ZEzhHajd6ZFlDAsSX703gL9exyPLMsYqqk/49eBV8
 k0KqEVcQRWuUbZoxVKGy63/CZtH2rnN07z9HmqJS+bjsYSuIBmFAEa6MCo30EC2HA7
 3jAsxLR5271uvS2Xmh/jpP4kHJaaqLxqX1olUKXWT7OEnQPF9H3sPrY68O4JvDy40n
 vSpMmk3rVG9MA==
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
In-Reply-To: <20190108.133053.2049686690825668341.davem@davemloft.net>
References: <20190107194733.31138-1-toke@toke.dk>
 <20190108.133053.2049686690825668341.davem@davemloft.net>
Date: Wed, 09 Jan 2019 09:37:33 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87pnt6teeq.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by
	using sch_cake as a leaf qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 08:37:38 -0000

David Miller <davem@davemloft.net> writes:

> From: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
> Date: Mon,  7 Jan 2019 20:47:29 +0100
>
>> This series fixes a couple of issues exposed by running sch_cake as a
>> leaf qdisc in an HFSC tree, which were discovered and reported by Pete
>> Heist. The interaction between CAKE's GSO splitting and the parent
>> qdisc's notion of its own queue length could cause queue stalls. While
>> investigating the report, I also noticed that several qdiscs would
>> dereference the skb pointer after dequeue, which is potentially
>> problematic since the GSO splitting code also frees the original skb.
>>=20
>> See the individual patches in the series for details.
>
> Toke, can you please resubmit this without patch #3.
>
> If you want to push for patch #3 still, it is much easier to submit
> it separately.

Can do :)

-Toke