Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Ryan Mounce <ryan@mounce.com.au>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed
Date: Thu, 26 Apr 2018 08:39:33 +0200	[thread overview]
Message-ID: <87po2m4gka.fsf@toke.dk> (raw)
In-Reply-To: <CAN+fvRYGMYahycxZAy35CJviJPn9eXqOczOih+LCTUGYBRLVBg@mail.gmail.com>

Ryan Mounce <ryan@mounce.com.au> writes:

> I'll investigate making the ACK filtering code safe, it is my mess after all :)
>
> Eric obviously understands this stuff a lot better than me, it looks
> like there are two issues?
> - Lack of minimum length check for TCP header, should be fairly
> straight-forward to fix
> - The possibility of unsafely filtering part of a split GSO
> super-packet?

The issue with the ACK filter in relation to GSO was just that a GSO
segment can't contain pure ACKs, so there's no reason to check after
splitting. I've already removed that part, so it's just the length
issue. I think it's just a matter of finding the length and calling
pskb_may_pull() (and aborting if that returns false).

-Toke

  parent reply	other threads:[~2018-04-26  6:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 20:45 Toke Høiland-Jørgensen
2018-04-26  1:10 ` Ryan Mounce
2018-04-26  1:32   ` Stephen Hemminger
2018-04-26  3:23     ` Dave Taht
2018-04-26  6:39   ` Toke Høiland-Jørgensen [this message]
2018-04-26  6:54     ` Ryan Mounce
2018-04-26  7:14       ` Toke Høiland-Jørgensen
2018-04-26  7:19 ` Kevin Darbyshire-Bryant
2018-04-26  7:34   ` Toke Høiland-Jørgensen
2018-04-26  8:43     ` Jonas Mårtensson
2018-04-26  8:55       ` Toke Høiland-Jørgensen
2018-04-26 12:02         ` Jonas Mårtensson
     [not found] ` <mailman.301.1524727201.3573.cake@lists.bufferbloat.net>
2018-04-26  7:26   ` Jonathan Morton
2018-04-26  7:43     ` Sebastian Moeller
2018-04-26 14:42       ` Jonathan Morton
2018-04-26 15:25         ` Sebastian Moeller
2018-04-27  0:17       ` David Lang
2018-04-26  8:16     ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po2m4gka.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=ryan@mounce.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox