From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 905B03CB38 for ; Thu, 8 Mar 2018 06:21:15 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520508074; bh=o+q+bL4KaEG0Ku1zUerl4YT3Z6P6JN/AbL+36yIJCX4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Uu+y4u6A3VGRAIhahRTUczgkbATDPQFWf1bbBEx3H5kb81zM7/sG7zJN+mLiWM4ZR dn6TnN7OeLYK1SdqwxlugvfJ2oWsAX0q8I0TP2Mk31+BIhdxBhtrJ1vt//YUXhfb9M W5C4kQjdVfAIo+Jmusw3jINM9RGaut78G6YJ36cAbSJdPtU0vJqjmtdphcna7gtuyz GRyUp6e+quE7fDUidNYYo2xfdk5i7EyXOB8T9v3rvIqJ1mk63uyuKnLpxWGJZfJ+8U fxcycv7BYw1bbsMVoUowlOTI5JwKK+ELS5tk+vD9D7pIkxb03zrQ54ISU7y58WwNR2 IneNEWORg2KtA== To: Stephen Hemminger Cc: "cake\@lists.bufferbloat.net" , Kevin Darbyshire-Bryant In-Reply-To: <04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk> References: <20180127130542.25817-1-toke@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> <87k1unlgck.fsf@toke.dk> <4654DB0C-74E6-46FB-9F62-119076D0A20B@darbyshire-bryant.me.uk> <87371a3ljk.fsf@toke.dk> <87sh9a25ta.fsf@toke.dk> <8B3F5A39-852D-41CE-B623-C65FCBA037FF@darbyshire-bryant.me.uk> <04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk> Date: Thu, 08 Mar 2018 12:21:14 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87po4e24ph.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 11:21:15 -0000 Kevin Darbyshire-Bryant writes: >> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant wrote: >>=20 >>=20 >>=20 >>> On 8 Mar 2018, at 10:57, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>=20 >>> Kevin Darbyshire-Bryant writes: >>>=20 >>>> Archer c7 v2. master branch of openwrt >>>=20 >>> Ah, great; I actually have one of those sitting on my desk that I could >>> potentially reflash without breaking anything too important. >>>=20 >>> In the meantime; do you get the same weird output on the >>> dropped/overlimit/requeues fields if you install a different qdisc than >>> cake? >>=20 >> From previous email this morning: >>=20 >>> Definitely dubious and I=E2=80=99m no longer convinced it=E2=80=99s a c= ake only issue. Looked at my AP which is running an older version of openw= rt, so older cake, older kernel etc etc and all qdiscs are returning odd im= possibly high values in a variety of fields. >>=20 >>=20 >>=20 >> tc -s qdisc >> qdisc noqueue 0: dev lo root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc fq_codel 0: dev eth1 root refcnt 4485644 limit 4497776p flows 4535= 164 quantum 4536072 target 5.0ms interval 100.0ms memory_limit 4Mb ecn >> Sent 74281480509 bytes 91321865 pkts (dropped 0, overlimits 0) >> maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 >> new_flows_len 0 old_flows_len 0 >> qdisc noqueue 0: dev br-lan root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev eth1.2 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev br-wifi_guest root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev eth1.15 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev wlan1 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev wlan0 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev wlan1-1 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> qdisc noqueue 0: dev wlan0-1 root refcnt 4485644 >> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>=20 >> And that=E2=80=99s on an openwrt system from commit f5b4f5f8e33624f27af9= fb3f86e09084181c08ed >> Author: Alif M. Ahmad >> Date: Sun Feb 25 03:18:41 2018 +0000 >>=20 >> So actually this problem has been around a little while, pre recent cake= changes. > > Oh and curiously the bad values go away if you ask for json output > it=E2=80=99s much better. Which rather points at a =E2=80=98feature=E2= =80=99 of the > =E2=80=98print_string=E2=80=99 behaviour. Right. Well, the print_* functions are behind several levels of pre-processor indirection, so not quite obvious what's going on here. Don't really see why they should spit out garbage values, though. Stephen, do you have any ideas? -Toke > > tc -s -j qdisc > [{ > "kind": "noqueue", > "handle": "0:", > "dev": "lo", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "fq_codel", > "handle": "0:", > "dev": "eth1", > "root": true, > "refcnt": 2, > "options": { > "limit": 10240, > "flows": 1024, > "quantum": 1514, > "target": 4999, > "interval": 99999, > "memory_limit": 4194304, > "ecn": true > } Sent 74283705614 bytes 91330210 pkts (dropped 0, overlimits 0) = maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 > new_flows_len 0 old_flows_len 0 > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "br-lan", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "eth1.2", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "br-wifi_guest", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "eth1.15", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "wlan1", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "wlan0", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "wlan1-1", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > },{ > "kind": "noqueue", > "handle": "0:", > "dev": "wlan0-1", > "root": true, > "refcnt": 2, > "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > } > ] > > >>=20 >>=20 >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake > > > Cheers, > > Kevin D-B > > 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A