Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Correct 'change' behaviour
Date: Tue, 03 Nov 2015 20:07:01 +0100	[thread overview]
Message-ID: <87pozqaomi.fsf@toke.dk> (raw)
In-Reply-To: <877flzas49.fsf@toke.dk> ("Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen=22's?= message of "Tue, 03 Nov 2015 18:51:34 +0100")

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> as best I can follow the logic in that function, it *should* actually
> get recreated when those flags are set.
>
> So why on earth are the values wrong? Memory initialisation problem?

Well, instrumenting cake with some good old-fashioned printk debug
statements, it appears that a replace when it's already in place does in
fact only call cake_change, and not cake_destroy followed by cake_init.

Now *why* that is I'm not entirely sure...

-Toke

  reply	other threads:[~2015-11-03 19:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 12:59 Toke Høiland-Jørgensen
2015-11-03 13:11 ` Kevin Darbyshire-Bryant
2015-11-03 13:14   ` Toke Høiland-Jørgensen
2015-11-03 17:24     ` Jonathan Morton
     [not found]       ` <87oafbat54.fsf@toke.dk>
2015-11-03 17:32         ` Jonathan Morton
2015-11-03 17:51           ` Toke Høiland-Jørgensen
2015-11-03 19:07             ` Toke Høiland-Jørgensen [this message]
2015-11-03 19:14               ` Dave Taht
2015-11-04 11:09                 ` Toke Høiland-Jørgensen
2015-11-04 14:28                   ` Sebastian Moeller
2015-11-04 18:04                   ` Kevin Darbyshire-Bryant
2015-11-04 18:51                     ` Toke Høiland-Jørgensen
2015-11-04 18:55                       ` Sebastian Moeller
2015-11-03 17:54     ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pozqaomi.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox