From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by huchra.bufferbloat.net (Postfix) with ESMTPS id D08C521F5DA
	for <cake@lists.bufferbloat.net>; Tue,  3 Nov 2015 11:07:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at mail2.tohojo.dk
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310;
	t=1446577622; bh=VQWgAK04rjGB4LW393hjP+ZxxjhnNdOiOJxiCs/ER3s=;
	h=From:To:Cc:Subject:References:Date:In-Reply-To;
	b=kgUFAZhyBXiJjW9kC6XjGZ0KJBasxohAu/jD8SxiK88ZQQKehK3gqLypQQG9fKdcv
	rsUWS7zsdXQRnJMAhmP0jCcXRwbCPCXE+Hw2K5Ss6EVWFtkpexvm+p3pzGpBePhCIl
	523qU+EFolaBVo7GewNNiDaDQbhdNAO7qc9uZ7pM=
Received: by alrua-karlstad.karlstad.toke.dk (Postfix, from userid 1000)
	id 739FC4EA8F9; Tue,  3 Nov 2015 20:07:01 +0100 (CET)
From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To: Jonathan Morton <chromatix99@gmail.com>
References: <87oafbnsqn.fsf@toke.dk>
	<5638B29D.9020503@darbyshire-bryant.me.uk> <87k2pzns29.fsf@toke.dk>
	<6F28B0F0-8333-4753-802E-BDDAC42CBC7B@gmail.com>
	<87oafbat54.fsf@toke.dk>
	<D80A799A-73D0-4BD5-8A75-8ACE287A3CC1@gmail.com>
	<877flzas49.fsf@toke.dk>
Date: Tue, 03 Nov 2015 20:07:01 +0100
In-Reply-To: <877flzas49.fsf@toke.dk> ("Toke =?utf-8?Q?H=C3=B8iland-J?=
	=?utf-8?Q?=C3=B8rgensen=22's?= message of
	"Tue, 03 Nov 2015 18:51:34 +0100")
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87pozqaomi.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Correct 'change' behaviour
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 19:07:28 -0000

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> as best I can follow the logic in that function, it *should* actually
> get recreated when those flags are set.
>
> So why on earth are the values wrong? Memory initialisation problem?

Well, instrumenting cake with some good old-fashioned printk debug
statements, it appears that a replace when it's already in place does in
fact only call cake_change, and not cake_destroy followed by cake_init.

Now *why* that is I'm not entirely sure...

-Toke