[Cake] CAKE build failure on Linux 4.2.2

[Cake] CAKE build failure on Linux 4.2.2

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Hi guys,

It appears that there are issues with building CAKE on a Linux kernel
4.2.2, due to relying on API that weren't released for the 4.2.2 release.
Perhaps the solution would be to either not support the 4.2.2 release or
use #ifdefs.

 Here are the errors:

make -C /lib/modules/4.2.2-1-ARCH/build SUBDIRS=/home/logan/sch_cake modules
make[1]: Entering directory '/usr/lib/modules/4.2.2-1-ARCH/build'
  CC [M]  /home/logan/sch_cake/sch_cake.o
/home/logan/sch_cake/sch_cake.c: In function ‘cake_hash’:
/home/logan/sch_cake/sch_cake.c:253:8: error:
‘FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL’ undeclared (first use in this
function)
        FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);
        ^
/home/logan/sch_cake/sch_cake.c:253:8: note: each undeclared identifier is
reported only once for each function it appears in
/home/logan/sch_cake/sch_cake.c:252:2: error: too many arguments to
function ‘skb_flow_dissect_flow_keys’
  skb_flow_dissect_flow_keys(skb, &keys,
  ^
In file included from include/linux/skbuff.h:37:0,
                 from /home/logan/sch_cake/sch_cake.c:46:
include/net/flow_dissector.h:173:20: note: declared here
 static inline bool skb_flow_dissect_flow_keys(const struct sk_buff *skb,
                    ^
scripts/Makefile.build:264: recipe for target
'/home/logan/sch_cake/sch_cake.o' failed
make[2]: *** [/home/logan/sch_cake/sch_cake.o] Error 1
Makefile:1386: recipe for target '_module_/home/logan/sch_cake' failed
make[1]: *** [_module_/home/logan/sch_cake] Error 2
make[1]: Leaving directory '/usr/lib/modules/4.2.2-1-ARCH/build'
Makefile:7: recipe for target 'default' failed

[-- Attachment #2: Type: text/html, Size: 2011 bytes --]

Re: [Cake] CAKE build failure on Linux 4.2.2

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 1892 bytes --]

I have a patch brewing. I will ask for a pull-request in a few hours :)



On Thu, Oct 8, 2015 at 10:57 AM, Loganaden Velvindron <loganaden@gmail.com>
wrote:

> Hi guys,
>
> It appears that there are issues with building CAKE on a Linux kernel
> 4.2.2, due to relying on API that weren't released for the 4.2.2 release.
> Perhaps the solution would be to either not support the 4.2.2 release or
> use #ifdefs.
>
>  Here are the errors:
>
> make -C /lib/modules/4.2.2-1-ARCH/build SUBDIRS=/home/logan/sch_cake
> modules
> make[1]: Entering directory '/usr/lib/modules/4.2.2-1-ARCH/build'
>   CC [M]  /home/logan/sch_cake/sch_cake.o
> /home/logan/sch_cake/sch_cake.c: In function ‘cake_hash’:
> /home/logan/sch_cake/sch_cake.c:253:8: error:
> ‘FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL’ undeclared (first use in this
> function)
>         FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);
>         ^
> /home/logan/sch_cake/sch_cake.c:253:8: note: each undeclared identifier is
> reported only once for each function it appears in
> /home/logan/sch_cake/sch_cake.c:252:2: error: too many arguments to
> function ‘skb_flow_dissect_flow_keys’
>   skb_flow_dissect_flow_keys(skb, &keys,
>   ^
> In file included from include/linux/skbuff.h:37:0,
>                  from /home/logan/sch_cake/sch_cake.c:46:
> include/net/flow_dissector.h:173:20: note: declared here
>  static inline bool skb_flow_dissect_flow_keys(const struct sk_buff *skb,
>                     ^
> scripts/Makefile.build:264: recipe for target
> '/home/logan/sch_cake/sch_cake.o' failed
> make[2]: *** [/home/logan/sch_cake/sch_cake.o] Error 1
> Makefile:1386: recipe for target '_module_/home/logan/sch_cake' failed
> make[1]: *** [_module_/home/logan/sch_cake] Error 2
> make[1]: Leaving directory '/usr/lib/modules/4.2.2-1-ARCH/build'
> Makefile:7: recipe for target 'default' failed
>

[-- Attachment #2: Type: text/html, Size: 2492 bytes --]

Re: [Cake] CAKE build failure on Linux 4.2.2

[Jonathan Morton]

> On 8 Oct, 2015, at 09:57, Loganaden Velvindron <loganaden@gmail.com> wrote:
> 
> It appears that there are issues with building CAKE on a Linux kernel 4.2.2, due to relying on API that weren't released for the 4.2.2 release. Perhaps the solution would be to either not support the 4.2.2 release or use #ifdefs.

So they’ve removed the old API while the new one still isn’t even halfway stable?  Wonderful.  Just when I thought I’d understood how it worked.

 - Jonathan Morton

Re: [Cake] CAKE build failure on Linux 4.2.2

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

On Thu, Oct 8, 2015 at 6:20 PM, Jonathan Morton <chromatix99@gmail.com>
wrote:

>
> > On 8 Oct, 2015, at 09:57, Loganaden Velvindron <loganaden@gmail.com>
> wrote:
> >
> > It appears that there are issues with building CAKE on a Linux kernel
> 4.2.2, due to relying on API that weren't released for the 4.2.2 release.
> Perhaps the solution would be to either not support the 4.2.2 release or
> use #ifdefs.
>
> So they’ve removed the old API while the new one still isn’t even halfway
> stable?  Wonderful.  Just when I thought I’d understood how it worked.
>

I have a patch for 4.2.x release brewing. I will ask for a Pull-up request
on github in a few hours :)



>
>  - Jonathan Morton
>
>

[-- Attachment #2: Type: text/html, Size: 1322 bytes --]

Re: [Cake] CAKE build failure on Linux 4.2.2

[Toke Høiland-Jørgensen]

Jonathan Morton <chromatix99@gmail.com> writes:

> So they’ve removed the old API while the new one still isn’t even
> halfway stable?  Wonderful.  Just when I thought I’d understood how it
> worked.

There's a reason the kernel people are adamant that they don't consider
internal APIs stable... ;)

-Toke

Re: [Cake] CAKE build failure on Linux 4.2.2

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Thu, Oct 8, 2015 at 2:20 PM, Jonathan Morton <chromatix99@gmail.com>
wrote:

>
> > On 8 Oct, 2015, at 09:57, Loganaden Velvindron <loganaden@gmail.com>
> wrote:
> >
> > It appears that there are issues with building CAKE on a Linux kernel
> 4.2.2, due to relying on API that weren't released for the 4.2.2 release.
> Perhaps the solution would be to either not support the 4.2.2 release or
> use #ifdefs.
>
> So they’ve removed the old API while the new one still isn’t even halfway
> stable?  Wonderful.  Just when I thought I’d understood how it worked.
>
>
See pull request:
https://github.com/dtaht/sch_cake/pull/13



>  - Jonathan Morton
>
>

[-- Attachment #2: Type: text/html, Size: 1411 bytes --]