From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Pete Heist <pete@heistp.net>, Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake srchost/dsthost stopped working?
Date: Wed, 04 Aug 2021 13:14:30 +0200 [thread overview]
Message-ID: <87r1f95und.fsf@toke.dk> (raw)
In-Reply-To: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net>
Pete Heist <pete@heistp.net> writes:
> One more tip, reverting this commit seems to fix it:
>
> https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7297c15d6ce
Ah, I think I see what the problem is; could you please try the patch
below?
-Toke
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 951542843cab..a83c4d4326da 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, const struct sk_buff *skb,
skip_hash:
if (flow_override)
flow_hash = flow_override - 1;
- else if (use_skbhash)
+ else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS)
flow_hash = skb->hash;
if (host_override) {
dsthost_hash = host_override - 1;
next prev parent reply other threads:[~2021-08-04 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 16:03 Pete Heist
2021-08-03 19:46 ` Pete Heist
2021-08-04 11:14 ` Toke Høiland-Jørgensen [this message]
2021-08-04 11:36 ` Jonathan Morton
2021-08-04 19:29 ` Toke Høiland-Jørgensen
2021-08-04 20:49 ` Pete Heist
2021-08-04 22:52 ` Pete Heist
2021-08-04 23:26 ` Jonathan Morton
2021-08-05 8:55 ` Pete Heist
2021-08-05 14:56 ` Toke Høiland-Jørgensen
2021-08-06 10:08 ` Pete Heist
2021-08-11 3:57 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1f95und.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox