From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [45.145.95.4])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id D7D223CB37
 for <cake@lists.bufferbloat.net>; Wed,  4 Aug 2021 07:14:35 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1628075672; bh=8gVXQTLdWKFdUlDsS0Mq/oGrOJZmPoeV5nSVtP5qkV0=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=TJUjksVkjdE2DfQxo80qY87LQC6HiH3z9MBuOTE85m7qLPtHQJiPzdqvbo9AfZhUz
 SBcYKx/8w9IeABU8fxj8Hwoq5R3EoggfxLIFipfl4ieL+vNti2IIpMEisVXXdvpKSt
 U6baeCFY0AMoSmQKBooBdqYXLOWrvXS5wQ1BXim6Ec37oRwJzY3UZUuG6jtvpag+0a
 eLIB0O8J9++vtuZi/H6UrWn6yhelpv7PUKM2XASUhlI5Y88zl8zrhgfbPbmQtDm6Fu
 i0kOaZH0BQJTvdfysjLzLuktX6ZAghhrVI4ogoA8jGq8COo9Tmt3e143V+LVzw7qFd
 mAlFloQvvtToQ==
To: Pete Heist <pete@heistp.net>, Cake List <cake@lists.bufferbloat.net>
In-Reply-To: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net>
References: <ae9f4679222f4eb3daa0e092446cb56da2fb85f6.camel@heistp.net>
 <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net>
Date: Wed, 04 Aug 2021 13:14:30 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87r1f95und.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Cake] cake srchost/dsthost stopped working?
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 11:14:36 -0000

Pete Heist <pete@heistp.net> writes:

> One more tip, reverting this commit seems to fix it:
>
> https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7297c15d6ce

Ah, I think I see what the problem is; could you please try the patch
below?

-Toke

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 951542843cab..a83c4d4326da 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, const struct sk_buff *skb,
 skip_hash:
        if (flow_override)
                flow_hash = flow_override - 1;
-       else if (use_skbhash)
+       else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS)
                flow_hash = skb->hash;
        if (host_override) {
                dsthost_hash = host_override - 1;