From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3B1A43BA8E for ; Fri, 15 Mar 2019 17:36:17 -0400 (EDT) Received: by mail-ed1-f66.google.com with SMTP id d6so8229679eds.2 for ; Fri, 15 Mar 2019 14:36:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=IURypKUufdBtuxJEChPg7g9eVw6szT2lIB0wqca5gxE=; b=Sqbq5mx1w+YnaeYEpksz1EhCYqvpbjyfkdfxgXnM6nsg3Ce/cMgrhuyvuKY/2u/K8Z eG8I0UpY5N1E7C7TyXTZbgDnZz3jviAufCKz+NCCeWCBDwL/Bzi03Smr4zywohtqdhks 3Ot0dcjMELAceWzBb9MKFZlI8hGNoZuNosg1Uy4nlXq26D8XwyPcZIOwZxgaHZ3w7caU YX/zOhtS/m3S97Oh5CdYoQUYY2WpLN6vK6NmYYJxP/USmbzuKwSiykUpdMiVchfiZTC3 q7XBoGtspGNnKre+yBKPA9LZoHJvnrhPzeDpoRW2Dm7QOglFYFbAFaHL8bQgOKlxFDzl vpFw== X-Gm-Message-State: APjAAAXebXgi+ZauATivCX1Zl4Z9DLakFEzDYFrpawndqlEAm891B18M V2/Z098WIsdKUnt7Tqi6o7wPkj4wlTA= X-Google-Smtp-Source: APXvYqyxG7qMjWAXcrvkonrvSqDXJ4EJsgjbyauP86xiyGVBK9s2W3phdhtGIhQfFx2BmJbJ3QhKfw== X-Received: by 2002:a17:906:5d2:: with SMTP id t18mr3529262ejt.144.1552685776419; Fri, 15 Mar 2019 14:36:16 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id c56sm974553edc.28.2019.03.15.14.36.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Mar 2019 14:36:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2FC721804A2; Fri, 15 Mar 2019 22:29:02 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: David Miller Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net, fuller@beif.de In-Reply-To: <20190315.115738.147858309937637.davem@davemloft.net> References: <20190314220822.19704-1-toke@redhat.com> <20190315.115738.147858309937637.davem@davemloft.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 15 Mar 2019 22:29:02 +0100 Message-ID: <87r2b7x1wh.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net] sch_cake: Interpret fwmark parameter as a bitmask X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 21:36:17 -0000 David Miller writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > Date: Thu, 14 Mar 2019 23:08:22 +0100 > >> We initially interpreted the fwmark parameter as a flag that simply turn= ed >> on the feature, using the whole skb->mark field as the index into the CA= KE >> tin_order array. However, it is quite common for different applications = to >> use different parts of the mask field for their own purposes, each using= a >> different mask. >>=20 >> Support this use of subsets of the mark by interpreting the TCA_CAKE_FWM= ARK >> parameter as a bitmask to apply to the fwmark field when reading it. The >> result will be right-shifted by the number of unset lower bits of the ma= sk >> before looking up the tin. >>=20 >> In the original commit message we also failed to credit Felix Resch with >> originally suggesting the fwmark feature back in 2017; so the Suggested-= By >> in this commit covers the whole fwmark feature. >>=20 >> Fixes: 0b5c7efdfc6e ("sch_cake: Permit use of connmarks as tin classifie= rs") >> Suggested-by: Felix Resch >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > You are lucky you decided to do this before a released kernel had this UA= PI > available. Yeah; did realise we needed to make this change before a release, so it's not entirely a coincidence that I sent this now :) > Applied. Thanks! -Toke