From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6FFC03CB35 for ; Fri, 15 Feb 2019 05:56:02 -0500 (EST) Received: by mail-ed1-f45.google.com with SMTP id r15so7568482eds.9 for ; Fri, 15 Feb 2019 02:56:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=brsY+8ZgStlQZWbtppAmMxVv8UM8WC9oQZxQdg1ALHQ=; b=L3Nm0Qu+G2+dgBdgRh85gjLXHYU9YbIIRdB2V11ira7DW/AvahiwnlBma/QWh9LOfg GNoruANEDnw5S1IWWsJq6+z1m66oRpmcMsBkJ6zi2+m8wkXJWUXs2nCnEnnd4hdssbmF Y2TADSeXMOVOVVZvtBnCqvRWipxLbsCZVLZJh0u/Ag9eljyXK/mGEPs1oxVRAf6oW3gz 4I7iT+1PXvM/WLMU/eeAJNpIln3Xg3b3UnZIDerBMXZBkgGR4KpP+0lFpHE5sEAg2XwC 8QS4orieVpa3x9/V5HsQJin2m4Cw1257cmkWgvwDXwwT8SxWttXpEJIEFbfgICBBxMUC dUhQ== X-Gm-Message-State: AHQUAubxJrJmcoXd+LD1rNlM9+e+5vxtCGBD9ej8/LYHnNGadbCzIXnP HhBXDCnXaKKboAIBPURbHibeog== X-Google-Smtp-Source: AHgI3IZgd4+tnGSz8LIGRGEJcOSL6jLQrZoBVLv7Q1XB/sJdEaOqNa4Rmquw5UGiYoKS+uenEEx4Ow== X-Received: by 2002:a50:da47:: with SMTP id a7mr6967809edk.101.1550228161484; Fri, 15 Feb 2019 02:56:01 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id h9sm1449236ede.93.2019.02.15.02.56.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Feb 2019 02:56:00 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E9C2B1825DD; Fri, 15 Feb 2019 11:55:59 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Adrian Popescu Cc: Cake List In-Reply-To: References: <87imxmwi8b.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 15 Feb 2019 11:55:59 +0100 Message-ID: <87r2c9s4lc.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Dropping dropped X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 10:56:02 -0000 Adrian Popescu writes: > On Thu, Feb 14, 2019 at 4:35 PM Toke H=C3=B8iland-J=C3=B8rgensen > wrote: > >> Adrian Popescu writes: >> >> > Hello, >> > >> > I've taken a look at cake's source code to see what simple changes cou= ld >> be >> > made to attempt to speed it up. There seemed to be a per flow variable >> > called dropped which might not be that useful for regular users. The >> > attached patch removes it. >> >> I appreciate the sentiment; however, we keep a lot of statistics for a >> reason, and we don't want to just drop those. Besides, a single variable >> increment is probably not going to make much difference for performance. >> > > Perhaps this seemed I implied that it was more than an experiment or > something meant to be merged. Is sharing a patch to start a conversation > frowned upon? Not at all. Just pointing out why this particular approach is probably not going to get you that far :) > The point is that low end routers can't run cake at high speeds. It > doesn't make sense to buy more expensive hardware for home networks. Yeah, I'm aware of the issue. However, I'm not too hopeful that it will be possible to squeeze significantly more performance out of the old hardware, sadly. I'd love to be proven wrong, though! -Toke