From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc
Date: Thu, 19 Jul 2018 17:20:09 +0200 [thread overview]
Message-ID: <87r2jz2qxi.fsf@toke.dk> (raw)
In-Reply-To: <a5ed73bd-b093-1fb9-a106-ae0b82efb7ff@gmail.com>
David Ahern <dsahern@gmail.com> writes:
> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote:
>> A few comments below; will fix the rest.
>>
>>>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth);
>>>> + print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth, b1));
>>>> + } else
>>>> + print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited");
>>>> + }
>>>> + if (tb[TCA_CAKE_AUTORATE] &&
>>>> + RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) {
>>>> + autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]);
>>>> + if(autorate == 1)
>>>> + print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress");
>
> This just caught me eye as well ... why the '_' after autorate?
Well, the parameter is called autorate_ingress to make it a single
token. When adding JSON support I picked the key/value representation
mostly because we could theoretically add other autorate modes in the
future (the netlink parameter allows it).
-Toke
next prev parent reply other threads:[~2018-07-19 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 16:39 Toke Høiland-Jørgensen
2018-07-16 17:06 ` Stephen Hemminger
2018-07-16 17:56 ` Toke Høiland-Jørgensen
2018-07-16 17:58 ` Stephen Hemminger
2018-07-18 2:31 ` David Ahern
2018-07-19 10:53 ` Toke Høiland-Jørgensen
2018-07-19 14:55 ` David Ahern
2018-07-19 15:20 ` Toke Høiland-Jørgensen [this message]
2018-07-19 15:22 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2jz2qxi.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox