From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AFAA03CB35 for ; Thu, 19 Jul 2018 11:20:24 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1532013623; bh=Oql1P2MJGuEW8Vi3UD7W0Hs46SKIRjJiAIPLPzcAIAM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E3MJXxLPrnW5o6GjrtLCwnZQBIHbkIB8mjmG4gaCS8KF5QNkk/Nx7u28VfabIkL4e lGfe5wy4t+/fSbomgcZrqxseKSVyvV2pOME3WZ6jD7lpKsRkkWHR+gWSEcprFrtaj/ 04muGx/p9rva6OI3KYuOiZghBppoLTGgtSj7Iq5ojV/lvmSYFvJ7rdEpPoRiqJZsN5 /rjwBiP9KVCHQJKmFuSe8XNgphGjB/am3JTjSAK0LvtT/9GV7jiez/OMV1qZLvkTW1 Q57kKBkdDeRacJ2RPT5vLQl89tXmqX7WfMCpwlARzwU7ia99BokG01FWkhR9fZrK4M iKG1CfU4Ru4cA== To: David Ahern , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht In-Reply-To: References: <20180716163926.4826-1-toke@toke.dk> <87bmb34htz.fsf@toke.dk> Date: Thu, 19 Jul 2018 17:20:09 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87r2jz2qxi.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 15:20:24 -0000 David Ahern writes: > On 7/19/18 4:53 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> A few comments below; will fix the rest. >>=20 >>>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >>>> + print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidt= h, b1)); >>>> + } else >>>> + print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited"); >>>> + } >>>> + if (tb[TCA_CAKE_AUTORATE] && >>>> + RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >=3D sizeof(__u32)) { >>>> + autorate =3D rta_getattr_u32(tb[TCA_CAKE_AUTORATE]); >>>> + if(autorate =3D=3D 1) >>>> + print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress"); > > This just caught me eye as well ... why the '_' after autorate? Well, the parameter is called autorate_ingress to make it a single token. When adding JSON support I picked the key/value representation mostly because we could theoretically add other autorate modes in the future (the netlink parameter allows it). -Toke