From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id ED91C3CB39
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 17:13:33 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1526505213; bh=L2U1NSyE2rclkgJq8fGTZMD1jMWaYw8SaAwfRqKg7rM=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=roba4LLAOpcqhwOKpL/61rmauyVM2moB250J3OfBFqOcvaWvlYESvq0sflBbaONXL
 21g+lSv9aJqFONhBwf5/kmOgBj8YJg749sMUcDm7n55s2TAgFMpYyeauA80Seuk8Hr
 D6a72tsxXK5arO71Szt19zVMii/JQ9zBAcXOVuSaG2/7fQqoY04tOTbR5eotnTGPQG
 LJ6fINNeeZUkNsELnGsplEnHDBdeaG8Yf+v1G9gU+1Ppfeu3Q2p1zK81Fi4ATxjip7
 c9e1YEqvQBpUIZSpN1OGhUGMm3exTIkxne4Lz+6mQQZhb1fSQEpGf0do4b3QFM53mz
 NGMfKgeHjapfw==
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
In-Reply-To: <CAM_iQpX0mfKJWjDE_2ofKftcr2KgaOkinm70-CdNtNSBj8_cJQ@mail.gmail.com>
References: <152650253056.25701.10138252969621361651.stgit@alrua-kau>
 <152650254604.25701.14673720046190425630.stgit@alrua-kau>
 <CAM_iQpX0mfKJWjDE_2ofKftcr2KgaOkinm70-CdNtNSBj8_cJQ@mail.gmail.com>
Date: Wed, 16 May 2018 23:13:28 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87r2mbuww7.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v12 1/7] sched: Add Common Applications
	Kept Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 21:13:34 -0000

Cong Wang <xiyou.wangcong@gmail.com> writes:

> On Wed, May 16, 2018 at 1:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen <toke@t=
oke.dk> wrote:
>> +
>> +static struct Qdisc *cake_leaf(struct Qdisc *sch, unsigned long arg)
>> +{
>> +       return NULL;
>> +}
>> +
>> +static unsigned long cake_find(struct Qdisc *sch, u32 classid)
>> +{
>> +       return 0;
>> +}
>> +
>> +static void cake_walk(struct Qdisc *sch, struct qdisc_walker *arg)
>> +{
>> +}
>
>
> Thanks for adding the support to other TC filters, it is much better
> now!

You're welcome. Turned out not to be that hard :)

> A quick question: why class_ops->dump_stats is still NULL?
>
> It is supposed to dump the stats of each flow. Is there still any
> difficulty to map it to tc class? I thought you figured it out when
> you added the tcf_classify().

On the classify side, I solved the "multiple sets of queues" problem by
using skb->priority to select the tin (diffserv tier) and the classifier
output to select the queue within that tin. This would not work for
dumping stats; some other way of mapping queues to the linear class
space would be needed. And since we are not actually collecting any
per-flow stats that I could print, I thought it wasn't worth coming up
with a half-baked proposal for this just to add an API hook that no one
in the existing CAKE user base has ever asked for...

-Toke