From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; dkim=pass header.d=toke.dk; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=toke.dk policy.dmarc=reject
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
	t=1772107536; bh=A5dFRRCQjsWGVb/MvbVCVM8MvJA8LbLiMMWYqv5yflI=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=IvwH9DoYYdKF9J3FjEqQYkV0sYW5LehRJLHm0OiCL1eD7GVONSeuD5gFqh2i0vJmB
	 SXW6JR18hvKxfylkfzmI0QPk2nfUZc7Q+5LODGL6GhvylxM9GhJgjG1Ytn/+cf73PI
	 rjRIz8JiRmpaC0sXDIn3HcV2rpRoJ/6ce+yHLNyzbIOMhA2zujWwGkJOsU86KxY/WT
	 t3FEKfa3N4inQTMQNkeSDitg3c9cfXHzcoeCbZDTahEKHeVZFjCO8oET3ib//GBl8+
	 leLnBCqMoGx/xkip7MYZlTmlNDZ1Ohipj7IvtPE83rbH8V5F/5lXzn9NGWlU7Q1yB9
	 +Vx+bw8qBhuKg==
To: Jonas =?utf-8?Q?K=C3=B6ppeler?= <j.koeppeler@tu-berlin.de>, Jamal Hadi
 Salim
 <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Simon Horman
 <horms@kernel.org>
Cc: cake@lists.bufferbloat.net, netdev@vger.kernel.org, Jonas =?utf-8?Q?K?=
 =?utf-8?Q?=C3=B6ppeler?=
 <j.koeppeler@tu-berlin.de>
In-Reply-To: <20260226-cake-mq-skip-sync-bandwidth-unlimited-v1-2-01830bb4db87@tu-berlin.de>
References: <20260226-cake-mq-skip-sync-bandwidth-unlimited-v1-0-01830bb4db87@tu-berlin.de>
 <20260226-cake-mq-skip-sync-bandwidth-unlimited-v1-2-01830bb4db87@tu-berlin.de>
Date: Thu, 26 Feb 2026 13:05:36 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87seanlnfz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: YH62MR75VNNFDU5FS32BQCNJSSVTXPAN
X-Message-ID-Hash: YH62MR75VNNFDU5FS32BQCNJSSVTXPAN
X-MailFrom: toke@toke.dk
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [Cake] Re: [PATCH net 2/2] net/sched: sch_cake: fixup cake_mq rate adjustment for diffserv config
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
Archived-At: <https://lists.bufferbloat.net/cake/87seanlnfz.fsf@toke.dk/>
List-Archive: <https://lists.bufferbloat.net/cake/>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Owner: <mailto:cake-owner@lists.bufferbloat.net>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Subscribe: <mailto:cake-join@lists.bufferbloat.net>
List-Unsubscribe: <mailto:cake-leave@lists.bufferbloat.net>

Jonas K=C3=B6ppeler <j.koeppeler@tu-berlin.de> writes:

> cake_mq's rate adjustment during the sync periods did not adjust the
> rates for every tin in a diffserv config. This lead to inconsistencies
> of rates between the tins. Fix this by setting the rates for all tins
> during synchronization.
>
> Fixes: 1bddd758bac2 ("net/sched: sch_cake: share shaper state across sub-=
instances of cake_mq")
> Signed-off-by: Jonas K=C3=B6ppeler <j.koeppeler@tu-berlin.de>

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>