From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dave Taht <dave.taht@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake's ack-filter vs GSO
Date: Fri, 23 Feb 2024 17:39:44 +0100 [thread overview]
Message-ID: <87sf1juobz.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw7y+S6NvRf+Q_VtqJkDnWQJO5Cr5d_En6wHvas6pEBT1w@mail.gmail.com>
Dave Taht <dave.taht@gmail.com> writes:
> On Sun, Feb 18, 2024 at 8:37 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> Dave Taht via Cake <cake@lists.bufferbloat.net> writes:
>>
>> > It has been years since I looked at cake's code.
>> >
>> > Does anyone remember why we do not ack-filter a gso-split?
>>
>> Because a GSO packet cannot be a pure ACK, so it wouldn't be filtered
>> anyway...
>
> But a GRO packet can, and most likely IS a pure ack packet train that
> could and should be thinned. I think. Yes?
Erm, no, because those would have header differences and so wouldn't be
combined into a single GRO packet...
-Toke
next prev parent reply other threads:[~2024-02-23 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 0:01 Dave Taht
2024-02-18 0:31 ` Jonathan Morton
2024-02-18 13:37 ` Toke Høiland-Jørgensen
2024-02-23 16:26 ` Dave Taht
2024-02-23 16:39 ` Toke Høiland-Jørgensen [this message]
2024-02-23 17:03 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf1juobz.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox