From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 8DC283B2A4
 for <cake@lists.bufferbloat.net>; Fri, 23 Feb 2024 11:39:47 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1708706385; bh=H/962ZOWn/EHiuvxRjDnNQMspY6xgO9jNmIpSsrnghA=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=XIIvt9KcZ61yAVWmjeKSjVAANJ/1+lrbiCQqWSngDY6dDlDd2s534GiEffUkbLTr4
 j/uF5mTsAS91G5DRT9+A+5wiIWXUHwoD5CC+fd3mh/vUNJukDAbKVShKgSv5pWRL0r
 qHCpI+CYhIsLk558mehNqXFi0I6EiDfsA9hppQjlpnoW9y+4B6my0o7H3E6oZ31CCj
 hhifSqLgPfs5+QjooxCvD6m/h8nyysMp/Jeei/UA8gLFgnfJ7KHYZ3LEsLA7clceOd
 PjQicE/ZQiT1dZGcBX3NKMYjPy/d45krJO79NUv8pNA9bHeR7fFKoZczwuX4ojl6s/
 B0EoRD/v0GVGA==
To: Dave Taht <dave.taht@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
In-Reply-To: <CAA93jw7y+S6NvRf+Q_VtqJkDnWQJO5Cr5d_En6wHvas6pEBT1w@mail.gmail.com>
References: <CAA93jw7YeW4wTC2OL4AxeEPBOGL4sKN+e5Dtre_0VZCkOjkbCw@mail.gmail.com>
 <875xyldhbk.fsf@toke.dk>
 <CAA93jw7y+S6NvRf+Q_VtqJkDnWQJO5Cr5d_En6wHvas6pEBT1w@mail.gmail.com>
Date: Fri, 23 Feb 2024 17:39:44 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87sf1juobz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] cake's ack-filter vs GSO
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2024 16:39:47 -0000

Dave Taht <dave.taht@gmail.com> writes:

> On Sun, Feb 18, 2024 at 8:37=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen =
<toke@toke.dk> wrote:
>>
>> Dave Taht via Cake <cake@lists.bufferbloat.net> writes:
>>
>> > It has been years since I looked at cake's code.
>> >
>> > Does anyone remember why we do not ack-filter a gso-split?
>>
>> Because a GSO packet cannot be a pure ACK, so it wouldn't be filtered
>> anyway...
>
> But a GRO packet can, and most likely IS a pure ack packet train that
> could and should be thinned. I think. Yes?

Erm, no, because those would have header differences and so wouldn't be
combined into a single GRO packet...

-Toke