* Re: [Cake] [PATCH net-next, v2 01/18] net/sched: sch_api: add helper for tc qdisc walker stats dump
[not found] <20220917050217.127342-1-shaozhengchao@huawei.com>
@ 2022-09-20 13:45 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; only message in thread
From: Toke Høiland-Jørgensen @ 2022-09-20 13:45 UTC (permalink / raw)
To: Zhengchao Shao, netdev, cake, linux-kselftest, jhs,
xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni,
vinicius.gomes, stephen, shuah, victor
Cc: zhijianx.li, weiyongjun1, yuehaibing, shaozhengchao
Zhengchao Shao <shaozhengchao@huawei.com> writes:
> The walk implementation of most qdisc class modules is basically the
> same. That is, the values of count and skip are checked first. If
> count is greater than or equal to skip, the registered fn function is
> executed. Otherwise, increase the value of count. So we can reconstruct
> them.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> include/net/pkt_sched.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
> index 29f65632ebc5..243e8b0cb7ea 100644
> --- a/include/net/pkt_sched.h
> +++ b/include/net/pkt_sched.h
> @@ -222,4 +222,17 @@ static inline struct tc_skb_cb *tc_skb_cb(const struct sk_buff *skb)
> return cb;
> }
>
> +static inline bool tc_qdisc_stats_dump(struct Qdisc *sch,
> + struct qdisc_walker *arg,
> + unsigned long cl)
> +{
> + if (arg->count >= arg->skip && arg->fn(sch, cl, arg) < 0) {
Seems a bit confusing that tc_qdisc_stats_dump() reverses the order of
the 'cl' and 'arg' parameters relative to the callback?
-Toke
^ permalink raw reply [flat|nested] only message in thread