From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: George Amanakis <gamanakis@gmail.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] Compiling under net-next
Date: Mon, 19 Mar 2018 11:40:27 +0100 [thread overview]
Message-ID: <87sh8wbb6s.fsf@toke.dk> (raw)
In-Reply-To: <87vadsbcag.fsf@toke.dk>
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> George Amanakis <gamanakis@gmail.com> writes:
>
>> It seems the change was introduced here:
>> https://patchwork.kernel.org/patch/9671147/
>>
>> I drafted the following very simplistic patch, could somebody take a
>> look at it?
>
> LGTM. We may want to actually use the extack feature at some point, but
> we're not really returning error messages from the configuration except
> when parsing fails, so I guess it doesn't matter too much in this
> instance...
Ah, wait, nla_parse_nested() takes an extack parameter now, so we should
pass that through in cake_change() after this change.
-Toke
next prev parent reply other threads:[~2018-03-19 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 20:00 Georgios Amanakis
2018-03-19 2:29 ` George Amanakis
2018-03-19 10:16 ` Toke Høiland-Jørgensen
2018-03-19 10:40 ` Toke Høiland-Jørgensen [this message]
[not found] ` <CACvFP_ijNbkUU8mRCyAwe16qZ=SYMStq=9QiyTBizNhLx-vZtw@mail.gmail.com>
2018-03-19 16:09 ` [Cake] Fwd: " Georgios Amanakis
2018-03-19 16:52 ` Toke Høiland-Jørgensen
2018-03-19 17:11 ` [Cake] [PATCH] Fixes for 4.16 George Amanakis
2018-03-20 9:33 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8wbb6s.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=gamanakis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox