From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id A44A63CB3C
 for <cake@lists.bufferbloat.net>; Mon, 19 Mar 2018 06:40:30 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1521456029; bh=jfWq7Fwn1vzRfDl6R9zIKmHu/WhwktmlnwWFwhDKXx4=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=xvGUQg90stWMDt+3I9bZJdimYo/2NWvuLO0DivUsLa3zRDvjlSzwNg77FUyHn84rO
 MKZHpbf6KP/8qnjg3YZztU/h+9vxb3g+0tgAdhZTnp89S6cfKU5rXmMV01eedW/uZC
 wm1z41nF/cYaZECxyBdHe0Yg0JuDq15fQBpTT83VorcEbdZCgFmkOo9UzAE8wURTbo
 2JnX8d124/aXXpQCl3wv35PPTtDk643ID0+y5XdK/bjoq6N8i13TJRyXh4lsRa6H+8
 g/2bO4svwwAiy2MIZdIweWbW8kiuNUpNujo1W5ermFQkUz7+214aMQinqzFJh/4tmQ
 rojeDsNRQ4vAg==
To: George Amanakis <gamanakis@gmail.com>, cake@lists.bufferbloat.net
In-Reply-To: <87vadsbcag.fsf@toke.dk>
References: <1521403235.24047.7.camel@gmail.com>
 <1521426571.28105.2.camel@gmail.com> <87vadsbcag.fsf@toke.dk>
Date: Mon, 19 Mar 2018 11:40:27 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87sh8wbb6s.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] Compiling under net-next
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 10:40:30 -0000

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> George Amanakis <gamanakis@gmail.com> writes:
>
>> It seems the change was introduced here:
>> https://patchwork.kernel.org/patch/9671147/
>>
>> I drafted the following very simplistic patch, could somebody take a
>> look at it?
>
> LGTM. We may want to actually use the extack feature at some point, but
> we're not really returning error messages from the configuration except
> when parsing fails, so I guess it doesn't matter too much in this
> instance...

Ah, wait, nla_parse_nested() takes an extack parameter now, so we should
pass that through in cake_change() after this change.

-Toke