From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CCBEA3CB44 for ; Wed, 7 Mar 2018 05:36:16 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520418975; bh=JHO7RPebteiWoYCjUlkDClkSqtoIlG48T9j/8qPaCEg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=vpZNSH11RRozr0OEN5wEolHdKUZifmKlKTwzIp8jH9qbjvN2C0SlKCTs/WT0DkYta Rw3uCMNb7VBtc35l7//8tlVvdsRe03VbZPNDidZkV2hNP6C1iJ+D6skX6VXg91GcwY M+arPAUELNhWJtGNGDxrPlc3CyaKnD4/JhK4hQbAhkqhcT088x822mflVKjKAxdOk0 AQWjhFP1T9Evh7k5VFWm2rZOrILUoE/vJbFSgH/993aVV01dFhQkBfb/H3133dQhTj RWo5qcKEHryidwlxEf+5wbSbmNrlQv8KlwcPWX1AI8r2tUBAHUoA9F6kifjerLFOhF ljp6/3l5vkQAw== To: Kevin Darbyshire-Bryant Cc: Jonathan Morton , "cake\@lists.bufferbloat.net" In-Reply-To: <87vae8yy68.fsf@toke.dk> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> Date: Wed, 07 Mar 2018 11:36:14 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87sh9cyxy9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 10:36:17 -0000 Toke H=C3=B8iland-J=C3=B8rgensen writes: > Kevin Darbyshire-Bryant writes: > >> Hi All, >> >> >> >>> On 7 Mar 2018, at 08:50, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>=20 >>> Jonathan Morton writes: >>>=20 >>>>> On 6 Mar, 2018, at 11:06 pm, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>=20 >>>>> ...on the iproute2 side the only >>>>> thing missing before we can attempt an upstream submission is an upda= te >>>>> of the man page, as far as I can tell. Any volunteers to do that? :) >>>>=20 >>>> I could look into that tomorrow. >>>=20 >>> Awesome! Is there anything else you want to add on the kernel side >>> before we submit? >> >> I think there was mention of the repo that Dave started on the last >> round of getting cake in upstream iproute2. There were a few man page >> tweaks & output formatting tweaks which ideally shouldn=E2=80=99t be los= t. >> I=E2=80=99ve forked that fork on github here >> https://github.com/ldir-EDB0/iproute2-cake-next/tree/cake rebased onto >> release tag v4.15.0 and pulled in the the recent changes (overhead >> handling paradigm, xstats & the JSON output). >> >> In theory I guess there should be no/little difference to tc-adv/master = now but=E2=80=A6. >> >> Anyway, it=E2=80=99s there if it=E2=80=99s of any interest=E2=80=A6 it= =E2=80=99ll be the basis of what >> gets sent into LEDE a bit later today. > > Please don't put something different into LEDE than what we're working > on upstreaming. It is difficult enough to keep track of the different > versions as they are. The tc-adv repo is already rebased on the upstream > iproute2-next, so if there is anything else that needs to be changed, it > should be changed in that repo and not in a fork... I pulled in the man page changes from Dave's iproute2-next fork to the tc-adv repo now... -Toke