From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 149183CB42 for ; Fri, 9 Feb 2018 08:08:21 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1518181700; bh=G13BPyZ7PIaPLyAz6P1BbfgOuIE6m+pBZeQKnFdnuZs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=euMGe8JFh8EXYrVbhiJYGns5W0hmDk9XFjy4+rcRBGgVfpPftClxQTdAgrgGGdvhA U7Sk0WS7fAHVf7Tc5x1BftcHfiN+ftt1hVfsz9Oy0q0YCQss+mtFYLak07k2KytF5E eks9URxVlR1WhvFpAB5qqBdxkXgLHfDkttSqe59IGF9p2CS2zcYj4bR2K5pqyoJvsl 8xEWP8Ga7k190QjvKz6Za4olLIHy78zCQPd6IeAITvqpnE40kutIK/GiIG86g/7kfj DAK7dBRsJRsmlP4XJ1CiV/KV/ABPplZVgYGYhPSKdZXlMBSKyQSmnlDJ1taKRSmYdu lRsc7x17NpsTQ== To: Jonathan Morton Cc: cake@lists.bufferbloat.net In-Reply-To: <195EF758-2260-4D9B-93D8-492D5E1307B2@gmail.com> References: <20171226150816.27668-1-toke@toke.dk> <20180127130542.25817-1-toke@toke.dk> <195EF758-2260-4D9B-93D8-492D5E1307B2@gmail.com> Date: Fri, 09 Feb 2018 14:08:19 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87shaafgzg.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH v2] Split tin stats to its own structure to decrease size of tc_cake_xstats X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 13:08:22 -0000 Jonathan Morton writes: >> On 27 Jan, 2018, at 3:05 pm, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >> This splits out the tin stats from tc_cake_xstats, which seems like the >> least intrusive way of decreasing the size of the stats structure. This >> way, we can send only the statistics corresponding to the actual number = of >> allocated tins, rather than having the xstats structure always be alloca= ted >> for the full number of tins. > > In order for this patch to work, we would need a corresponding patch > for iproute2 so that it can successfully read the new structure - > including correcting for changes in the size field. Yup, that's on my list; haven't gotten around to it yet... :) -Toke